Deprecate responseJSON #3502
Merged
Deprecate responseJSON #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshier
force-pushed
the
update/deprecate-responseJSON
branch
from
f89bb13
to
dc7416d
Compare
jshier
added a commit
that referenced
this pull request
Jan 15, 2022
* Deprecate responseJSON. * Fix tests. * Fix tests for responseDecodable. * Increase upload size for reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Despite the extensive documentation,
responseJSONseems to be greatly misunderstood. As I've observed in many code samples on StackOverflow and elsewhere, people seem to think you need to call it for every response that returns JSON, even if you then want to useJSONDecoderon theDatareturned. Since this convenience is largely unneeded nowadays, it seems like a good idea to deprecate and point everyone to the much superiorresponseDecodable.Implementation Details 🚧
This PR simply deprecates the
responseJSONmethods andJSONResponseSerializer.Testing Details 🔍
This PR updates our tests to replace
responseJSONwithresponseDecodable, except for tests which exercisedresponseJSONspecifically, which have themselves been deprecated as well.