Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample app: display the initial loading state for each Request #3514

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

TiagoMaiaL
Copy link
Contributor

@TiagoMaiaL TiagoMaiaL commented Nov 1, 2021

Goal ⚽

To display the initial loading state for each Request object in the DetailViewController of the sample application.

Before the change

After the change

Implementation Details 🚧

This change simply displays the refreshIndicator of the UITableView. For some reason the tint color isn't applied.
As an alternative, a backgroundView with an UIActivityIndicator can be added to the UITableView in order to display this initial loading state, with the proper color and layout position (centered).

@TiagoMaiaL TiagoMaiaL changed the title Sample app: Display the initial loading state for each Request Sample app: display the initial loading state for each Request Nov 1, 2021
Copy link
Contributor

@jshier jshier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Makes sense, thanks!

@jshier jshier merged commit 871483e into Alamofire:master Nov 3, 2021
@TiagoMaiaL TiagoMaiaL deleted the display-initial-loading-sample branch November 3, 2021 18:02
@jshier jshier added this to the 5.5.0 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants