Sort acceptable content-types in error messages

[Usipov]

Goals ⚽

To make serialization error texts less random which comes in handy when you log those errors from you mobile apps.

Currently I get errors like:

Request failed due to an underlying Alamofire error: Response Content-Type "image/webp" does not match any acceptable types: application/octet-stream,image/bmp,image/gif,image/heic,image/heif,image/ico,image/jp2,image/jpeg,image/jpg,image/png,image/tiff...

where acceptable types are listed in a random order. By making error texts more deterministic we get better compression on the errors storage and also a more reliable error counter

[jshier]

Thanks for the PR! Just a few notes, then I think this is good to go.

[jshier]

By making error texts more deterministic we get better compression on the errors storage and also a more reliable error counter

I'm not sure what you mean here. There's no compression on error storage (the strings are generated when you print their description) and I'm not sure what you mean by "error counter". In any case, the sorting should help with readability and figuring out whether your particular type is in the list or not.

[Usipov]

I'm not sure what you mean here. There's no compression on error storage (the strings are generated when you print their description) and I'm not sure what you mean by "error counter". In any case, the sorting should help with readability and figuring out whether your particular type is in the list or not.

We store all error texts in a database, group them by uniq text and then count. So, having lots of kinda different errors affects both the storage and the counter

[Usipov]

@jshier, could you please revisit the PR? 🙏
Do I understand it right, that after merging the PR you (not me) will release a new version?

[Usipov]

Workflow runs completed with no jobs

That's strange 🤔

I tested locally: everything is ok on all the platforms (some macOS tests very flaky, though, but not my new one)

[jshier]

Thanks for the better test. I have some naming notes, otherwise it looks good.

[Usipov]

@jshier 🙏

[jshier]

👍 Looks good, thanks!

[Usipov]

@jshier, thanks for the review!
Do I understand it right, that you (not me) will release a new version?

[jshier]

Yes, this will go out with out next release. I'm aiming to do it around the time Apple releases Xcode 13.2.