Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Swift version check across all platforms #3549

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Added a Swift version check across all platforms #3549

merged 1 commit into from
Jan 24, 2022

Conversation

daveverwer
Copy link
Contributor

@daveverwer daveverwer commented Jan 24, 2022

Issue Link 🔗

No direct issue, but prompted by the discussion here: https://forums.swift.org/t/54715

Goals ⚽

To reliably prevent the package from compiling when using Xcode 11 or Swift < 5.3 so the Swift Package Index can more accurately determine platform and Swift version compatibility. See the build success for watchOS with Xcode 11.6 here: https://swiftpackageindex.com/Alamofire/Alamofire/builds

@jshier jshier merged commit 6de3f65 into Alamofire:master Jan 24, 2022
@jshier
Copy link
Contributor

jshier commented Jan 24, 2022

Thanks Dave!

@daveverwer
Copy link
Contributor Author

Thanks Jon. What a speedy merge!

@jshier jshier added this to the 5.6.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants