Require Swift 5.6 Compiler for Concurrency Support #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven0351
added a commit
to ionic-team/ionic-portals-ios
that referenced
this pull request
Apr 14, 2022
for Swift Concurrency. First discovered this in Alamofire/Alamofire#3590.
Steven0351
added a commit
to ionic-team/ionic-portals-ios
that referenced
this pull request
Apr 18, 2022
* fix: Bumps the required Swift version to 5.6 to address potential issue for Swift Concurrency. First discovered this in Alamofire/Alamofire#3590.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3529
Goals ⚽
This PR bumps the Swift compiler version required to build the concurrency features to 5.6, as Xcode 13.3.1 finally fixes the long line of bugs Apple shipped. Unfortunately I can't precisely require 13.3.1, just 5.6, which also shipped with Xcode 13.3, so the BitCode bug can still hit people, but it's fixed simply by updating Xcode.
Implementation Details 🚧
This PR simply bumps the required version to build, not functional changes.
Testing Details 🔍
Concurrency tests also bumped to require Swift 5.6.