Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Manual Refactoring #21

Open
wants to merge 5 commits into
base: master
from

Conversation

@ConsoleTVs
Copy link

commented Oct 7, 2019

Manual refactoring of the client to meet some of the standards and clean up the code.

This pull request has NOT been tested, therefore, manual testing is required.

@ConsoleTVs

This comment has been minimized.

Copy link
Author

commented Oct 7, 2019

@AlbertSuarez AlbertSuarez requested review from AlbertSuarez and daleu Oct 9, 2019
@AlbertSuarez

This comment has been minimized.

Copy link
Owner

commented Oct 9, 2019

We'll take a look @ConsoleTVs . Thanks a lot for your contribution! 🙌

Copy link
Owner

left a comment

I've built it and something change with the next/back buttons because they don't show now. Please find an image attached below:

image

Feel free to update your PR with the needed changes for that.

Thanks anyways!

@ConsoleTVs

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

The CSS is a bit messy in here.
image

And aparently, the footer is there, but somehow hidden:

image

May you guys take a look at it when you have some free time? btw; I also removed dozens of TS warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.