Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5, Alchemy 4, Devise 4 #58

Merged
merged 9 commits into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@tvdeyen
Copy link
Member

commented Jul 13, 2017

Updates to Alchemy 4 and Devise 4 with support for Rails 5.

@tvdeyen

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2017

The vast majority of these changes are the Rails 5 updates of the dummy app.

@tvdeyen tvdeyen requested a review from mamhoff Jul 13, 2017

@mamhoff
Copy link
Contributor

left a comment

Go for it, I see no blockers here.

tvdeyen added some commits Jul 13, 2017

Use Alchemy 4.0 and Devise 4.0
These versions support Rails 5
Install rails controller testing gem
Some specs are depending on it.
Silence deprecations during test runs
We tackle deprecations later
Fixes user sessions controller specs
Rails 5 controller tests does not work with rspec request stubs
anymore. Needed to stub ActionController::TestRequest instead.
Use ActiveJob "test" queue adapter in specs
In order to test deliver_later properly we use the test queue adapter.
Update travis build config
- Only build ruby versions that are compatible with Rails 5
- Uses trusty distro

@tvdeyen tvdeyen force-pushed the alchemy-4 branch from 31e554b to f771734 Jul 17, 2017

@tvdeyen tvdeyen merged commit a2e71b7 into master Jul 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tvdeyen tvdeyen deleted the alchemy-4 branch Jul 17, 2017

@tvdeyen tvdeyen added this to the 4.0 milestone Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.