Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Do not cache the essence view partials
Caching the essence view partials does not make any sense, when the element is already cached. The essence views has no complex computation or DB queries, but lots of moving parts (`html_options`, `options`). Caching them is more harmful then helpful.
- Loading branch information
Thomas von Deyen
committed
Aug 4, 2016
1 parent
599ea92
commit 4bb35cf862e9c55e686c63c44da657d237b680cb
Showing
10 changed files
with
10 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -2,6 +2,10 @@ | ||
|
||
## 3.5.0 (unreleased) | ||
|
||
__Notable Changes__ | ||
|
||
* The essence view partials don't get cached anymore (#1099) | ||
|
||
## 3.4.0 (2016-08-02) | ||
|
||
__New Features__ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,3 +1 @@ | ||
<%- cache(content) do -%> | ||
<%= Alchemy.t(content.ingredient) -%> | ||
<%- end -%> | ||
<%= Alchemy.t(content.ingredient) -%> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,3 +1 @@ | ||
<% cache(content) do %> | ||
<%= raw content.ingredient -%> | ||
<% end %> | ||
<%= raw content.ingredient -%> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,7 +1,5 @@ | ||
<% cache(content) do %> | ||
<%= Alchemy::EssencePictureView.new( | ||
content, | ||
local_assigns[:options], | ||
local_assigns[:html_options] | ||
).render %> | ||
<% end %> | ||
).render %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,5 +1,3 @@ | ||
<%- cache(content) do -%> | ||
<%- options = local_assigns.fetch(:options, {}) -%> | ||
<%- plain_text = !!content.settings_value(:plain_text, options) -%> | ||
<%= raw content.essence.send(plain_text ? :stripped_body : :body) -%> | ||
<%- end -%> | ||
<%= raw content.essence.public_send(plain_text ? :stripped_body : :body) -%> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,3 +1 @@ | ||
<% cache(content) do %> | ||
<%= content.ingredient %> | ||
<% end %> | ||
<%= content.ingredient %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters