Permalink
Commits on Mar 30, 2017
  1. Merge pull request #1246 from AlchemyCMS/fix_datepicker

    Render "text" as type for datepicker input fields
    robinboening committed on GitHub Mar 30, 2017
Commits on Mar 29, 2017
  1. Merge pull request #1253 from rbjoern84/meta-charset-utf-8

    Change meta charset from 'utf8' to 'utf-8'
    tvdeyen committed on GitHub Mar 29, 2017
  2. Change meta charset from 'utf8' to 'utf-8'

    rbjoern84 committed Mar 29, 2017
Commits on Mar 20, 2017
  1. Render "text" as type for datepicker input fields

    - [x] Refactor the way the datepicker is initialized
    
    This change fixes an issue that appears when you are using a type `date` field. What happens is that google chrome renders its HTML5 input field for dates but complains if the date format is not the same as defined in the users OS settings. You can still save new values, but since the values are localized by Rails they are not being presented in the input field (happens when you enter the page or reload). #1245
    robinboening committed Mar 10, 2017
Commits on Feb 23, 2017
  1. Merge pull request #1229 from AlchemyCMS/legacy-page-request-specs

    Convert legacy page redirect spec into request spec
    mamhoff committed on GitHub Feb 23, 2017
  2. Convert legacy page redirect spec into request spec

    Rails controller spec are unit tests to controllers where
    the routing and lots of Rails' internals are stubbed.
    
    Request specs test run with the same internals as in a real request.
    
    Also removes lots of stubbing in the specs itself, that's why
    these tests fail on Rails 5.
    
    By rewriting them into request specs they even work with Rails 5.
    tvdeyen committed Jan 23, 2017
  3. Merge pull request #1230 from AlchemyCMS/harden-content-spec

    Remove excessive stubbing from contents controller spec
    tvdeyen committed on GitHub Feb 23, 2017
  4. Merge pull request #1225 from AlchemyCMS/raise-dragonfly-version

    Use at least dragonfly 1.0.7
    tvdeyen committed on GitHub Feb 23, 2017
Commits on Feb 6, 2017
  1. Merge pull request #1224 from AlchemyCMS/no-arrays-in-breadcrump

    Don't convert AR relations to arrays in breadcrump
    mamhoff committed on GitHub Feb 6, 2017
Commits on Feb 2, 2017
  1. Merge pull request #890 from nielspetersen/pass-content-length-respon…

    …se-header
    
    Transmit content length for attachments
    tvdeyen committed on GitHub Feb 2, 2017
  2. Merge pull request #1239 from AlchemyCMS/bye-bye-seeder

    Bye bye seeder
    mamhoff committed on GitHub Feb 2, 2017
  3. Seeder does not create scaffold anymore

    The seeder now only works for seeding pages and users. The default site, their default language and the root page are now created the time they are accessed the first time. There is no need to seed them anymore.
    tvdeyen committed Feb 2, 2017
  4. Do not seed in specs anymore

    Alchemy now handles creation of default site, root pages and default languages without the need of seeding the database.
    tvdeyen committed Feb 2, 2017
  5. Create root page if none is present

    When accessing `Page.root` and no root page is present yet, we create one.
    
    This let’s us get rid of the seeder in the future.
    tvdeyen committed Feb 1, 2017
  6. Set the default page layout for new languages

    When an admin creates a new language the default page layout should be already set.
    
    The former spec was testing behavior that does not exist and the check for the presence of the default languages configuration was moved into the Site model recently.
    tvdeyen committed Feb 1, 2017
  7. Raise while creating default language in site model

    Since we now create the default site the time we try to load it the first time and the site creates it’s own default language, we don’t need to check for the default language anymore.
    
    Instead we raise an error if the configuration for default language can’t be found in the site model while we create the default language for that site.
    tvdeyen committed Feb 1, 2017
  8. Create default site when not present yet

    When we ask for `Alchemy::Site.default` we want to get the default site everytime, even when it’s not present yet. That’s why we create it when necessary.
    
    This will help us to get rid of the seeder in the future.
    tvdeyen committed Feb 1, 2017
  9. Merge pull request #1236 from AlchemyCMS/permit-search-params

    Permit search params while redirecting in library
    tvdeyen committed on GitHub Feb 2, 2017
  10. Merge pull request #1240 from AlchemyCMS/remove-unused-page-attributes

    Remove unused Page attr_accessors
    mamhoff committed on GitHub Feb 2, 2017
  11. Remove unused Page attr_accessors

    Page `:do_not_sweep` and `:do_not_validate_language` are left overs from acient times.
    tvdeyen committed Feb 1, 2017
  12. Merge pull request #1238 from AlchemyCMS/add-config-stubbing-helper

    Add a configuration stubbing helper
    tvdeyen committed on GitHub Feb 2, 2017
Commits on Feb 1, 2017
  1. Use stub_alchemy_config to stub config in specs

    Eat your own dog food
    tvdeyen committed Feb 1, 2017
  2. Add a configuration stubbing helper

    In order to be able to stub Alchemy configuration you can use this helper in you specs.
    
    Require and include `alchemy/test_support/config_stubbing` in your RSpec config.
    
        RSpec.configure do |config|
          config.include Alchemy::TestSupport::ConfigStubbing
        end
    tvdeyen committed Feb 1, 2017
Commits on Jan 31, 2017
  1. Permit search params while redirecting in library

    Former we build a hash of parameters to pass along while redirecting
    in attachment and picture library. In Rails 5 this leads to errors.
    
    By explicitely permitting the parameters we want to pass along, we
    avoid these errors and even enhance security.
    tvdeyen committed Jan 31, 2017
Commits on Jan 30, 2017
  1. Transmit content length for attachments

    nielspetersen committed with nielspetersen Oct 13, 2015
  2. Merge pull request #1234 from AlchemyCMS/fix-essence-picture-controll…

    …er-spec
    
    Only allow floats and ints as fixed ratio for crop
    mamhoff committed on GitHub Jan 30, 2017
  3. Only allow floats and ints as fixed ratio for crop

    Former we only checked if a fixed ratio was passed or not by checking its existence.
    In Rails 5 all param values are strings, even booleans. This leads to NaN errors.
    By checking the value to match an integer or float string we make sure this does
    not happen any more.
    tvdeyen committed Jan 30, 2017
Commits on Jan 23, 2017
  1. Remove excessive stubbing from contents controller spec

    The contents controller spec stubbs everything happening along the
    way to the content model.
    
    By using real objects we test what really should happen.
    tvdeyen committed Jan 23, 2017
Commits on Jan 8, 2017
  1. Use at least dragonfly 1.0.7

    Dragonfly < 1.0.7 has security issues fixed with 1.0.7
    
    See: https://hakiri.io/technologies/dragonfly/issues/b1dab2e1699d03
    tvdeyen committed Jan 8, 2017
  2. Don't convert AR relations to arrays in breadcrump

    Previously we converted the active record relation for pages
    in the breadcrump helper into arrays to support options like
    `:reverse` and `:without`.
    
    Now we use the active record counterparts `#reorder` and `where.not` instead.
    We could cache the breadcrumb views now if someone wanted to.
    
    Also the implementation used in-self-replaced calls (`#reverse!` and `#delete`)
    that where called on new arrays through `#to_a`, which lead to bugs in Rails 5.
    tvdeyen committed Jan 8, 2017
  3. Merge pull request #1223 from AlchemyCMS/harden-admin-attachments-dow…

    …nload-spec
    
    Hardens the admin attachments download spec
    tvdeyen committed on GitHub Jan 8, 2017
  4. Merge pull request #1221 from AlchemyCMS/options-params-parser

    Future proof option params parsing
    mamhoff committed on GitHub Jan 8, 2017
Commits on Jan 6, 2017
  1. Hardens the admin attachments download spec

    By stubbing too much of what happens inside the controller
    this test actually tests nothing.
    
    By using the same expectation on the response object like
    we already do in the frontend attachment download spec we
    make this test future proof for Rails 5 and beyond.
    tvdeyen committed Jan 6, 2017
  2. Future proof option params parsing

    Previously we dealed with Strings, Hashes and Arrays (which are obviously never used, because we symbolised keys in all cases).
    
    Now only distinguish between JSON strings and ActionController::Parameters, everything else is never used and have a Hash fallback for emtpy strings and nil.
    
    By not asking explicitly for Hash anymore we are future proof as Rails 5 doesn't inherit from Hash for ActionContoller::Params anymmore.
    tvdeyen committed Jan 6, 2017
  3. Merge pull request #1220 from AlchemyCMS/refactor-uploader-specs

    Refactor uploader specs for attachment and picture
    mamhoff committed on GitHub Jan 6, 2017