Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Needless class-method? (PageLayout.get_page_layout_names) #258

robinboening opened this Issue · 1 comment

2 participants


Two things for discussion on the class-method get_page_layout_names:

1.) Its is not used in the whole Alchemy gem.

2.) The return value is an array. But in that array there are the keys listed, not the values! For better understanding the return value looks like this: ["name", "name", "name", "name"] Thats definitivly wrong.

Do we want to remove this method? Or do we want to fix the return value?

@robinboening robinboening was assigned

Delete your code!

@robinboening robinboening closed this issue from a commit
@robinboening robinboening Removes class method 'get_page_layout_names' from PageLayout. Closes #…

This was a needless class method because it was never used anywhere in alchemy.

Even though the name suggests the return value would be the page_layout names, this is not the case. Instead it returned the keys…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.