Fix factory loading #2041
Merged
Fix factory loading #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the method returned a list of individual file paths. FactoryBot is able to load files from a directory. By changing this to factories_path and return a single directory path it is easier to prepend and append the path to the list of factory bots factory definitions.
Our factories now get appended to the definition paths of factory bot. Also FactoryBot.reload is wrong as it resets the internal configs of factory bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Before the method returned a list of individual file paths. FactoryBot is able to load files from a directory. By changing this to
factories_pathand return a single directory path it is easier to prepend and append the path to the list of factory bots factory definitions.Also
FactoryBot.reloadis wrong as it resets the internal configs of factory bot.Checklist