Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option to add a comment to every select's option #418

Merged
merged 14 commits into from May 17, 2022

Conversation

luanraithz
Copy link
Contributor

@luanraithz luanraithz commented Apr 27, 2022

This is the pull request mentioned on #416

Copy link
Owner

@AlecAivazis AlecAivazis left a comment

Straight forward implementation and works as expected - nice!

Will merge this in once we get the 👍 from GH

@AlecAivazis
Copy link
Owner

AlecAivazis commented May 10, 2022

@luanraithz the tests are failing - mind fixing them?

@luanraithz
Copy link
Contributor Author

luanraithz commented May 11, 2022

Sorry, didn't see that. I'm on it

Copy link
Collaborator

@mislav mislav left a comment

I love this feature! Thanks for adding it.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,53 @@
package main
Copy link
Collaborator

@mislav mislav May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the file meals.go be named something more descriptive of the feature it's demoing, such as select_description.go?

examples/meals.go Outdated Show resolved Hide resolved
examples/meals.go Outdated Show resolved Hide resolved
@luanraithz luanraithz requested a review from mislav May 11, 2022
@luanraithz
Copy link
Contributor Author

luanraithz commented May 11, 2022

I think it's all solved, thanks for the review!

mislav
mislav approved these changes May 17, 2022
Copy link
Collaborator

@mislav mislav left a comment

Thank you!

@mislav mislav merged commit c2be27f into AlecAivazis:master May 17, 2022
5 of 6 checks passed
@dvaghela
Copy link

dvaghela commented Jun 7, 2022

@AlecAivazis How soon can we expect a release with this PR?
And thanks for the project, it is really great! 😄

@AlecAivazis
Copy link
Owner

AlecAivazis commented Jun 7, 2022

Thanks for the ping! It's now been released as 2.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants