Fix Time Format Error #4

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
2 participants
@webdepp
Contributor

webdepp commented Jan 4, 2017

In local timezone setting, actualTime is in 12h format as default, which doesn't correspond with internal format.
Therefore, set 24h format as defined option.

Fix Time Format Error
In local timezone setting, actualTime is in 12h format as default, which doesn't correspond with our internal format.
Therefore, set 24h format as defined option.
@Alex-Werner

This comment has been minimized.

Show comment
Hide comment
@Alex-Werner

Alex-Werner Jan 10, 2017

Owner

Sorry, I didn't saw that earlier !
Seems good to me, I will check this properly this evening and merge it.

I want to thank you a lot for your PR on this little project. <3

Owner

Alex-Werner commented Jan 10, 2017

Sorry, I didn't saw that earlier !
Seems good to me, I will check this properly this evening and merge it.

I want to thank you a lot for your PR on this little project. <3

@Alex-Werner

This comment has been minimized.

Show comment
Hide comment
@Alex-Werner

Alex-Werner Jan 10, 2017

Owner

Fixed : #2

Owner

Alex-Werner commented Jan 10, 2017

Fixed : #2

@Alex-Werner Alex-Werner merged commit 3cae0dd into Alex-Werner:master Jan 10, 2017

@webdepp

This comment has been minimized.

Show comment
Hide comment
@webdepp

webdepp Jan 10, 2017

Contributor

Ha... I didn't even see that there was already an issue open.
Cheers!

Contributor

webdepp commented Jan 10, 2017

Ha... I didn't even see that there was already an issue open.
Cheers!

@Alex-Werner

This comment has been minimized.

Show comment
Hide comment
@Alex-Werner

Alex-Werner Jan 10, 2017

Owner

Yeah, I had the same issue on a different server. I had figured out what was the problem, then forgot to indead fix it.
It was planned in a commit that has a months of delay (with a codebase clean-up, as it's a freaking mess, an internal documentation and some new format for setting up cron - like the std cron format), but never finished as I seeked more about the Node Event Loop (a stuff I want to implement at the same time as I want to make it deterministic in order to be able to retrieve any blocking-event job done).

So thank you again for the help here :)
Cheers!

Owner

Alex-Werner commented Jan 10, 2017

Yeah, I had the same issue on a different server. I had figured out what was the problem, then forgot to indead fix it.
It was planned in a commit that has a months of delay (with a codebase clean-up, as it's a freaking mess, an internal documentation and some new format for setting up cron - like the std cron format), but never finished as I seeked more about the Node Event Loop (a stuff I want to implement at the same time as I want to make it deterministic in order to be able to retrieve any blocking-event job done).

So thank you again for the help here :)
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment