Permalink
Browse files

Mongo now passes tests on Clojure 1.3.x. Can also execute examples fr…

…om 2010/01/03 blog post
  • Loading branch information...
1 parent 13e0504 commit e6307d6de154e684d5912c984839caf7636a4232 @mtnygard mtnygard committed Sep 9, 2011
Showing with 25 additions and 9 deletions.
  1. +1 −0 .gitignore
  2. +15 −0 README.textile
  3. +3 −2 modules/incanter-core/src/incanter/core.clj
  4. +3 −4 modules/incanter-mongodb/project.clj
  5. +3 −3 project.clj
View
@@ -8,3 +8,4 @@ classes
*.jar
*.log
.cake
+.lein-failures
View
@@ -183,3 +183,18 @@ h3. Dynamic vars
declared as such. They aren't rebound in incanter-core, but the
docstring for test-statistic-distribution implies than an
application can rebind them, so I'm adding @^:dynamic@ to the decls.
+* $data was not declared as dynamic, could not be rebound. Workaround:
+ added ^{:dynamic true} to metadata. Open question: does rebinding
+ this fit in the 1.3 model for vars? Check with Stu about threading.
+
+
+h3. Missing tests
+
+These are things I caught by running examples by hand, but were not
+picked up by any test cases.
+
+* $data not used in -core
+
+* Running the first "with-data" function on
+ http://data-sorcery.org/2010/01/03/datasets_mongodb/ revealed that
+ "sel" was not being exercised in -core.
@@ -52,9 +52,10 @@
(java.util Vector)))
- (def ^{:doc "This variable is bound to a dataset when the with-data macro is used.
+(def ^{:dynamic true
+ :doc "This variable is bound to a dataset when the with-data macro is used.
functions like $ and $where can use $data as a default argument."}
- $data)
+ $data)
(defrecord Dataset [column-names rows])
(derive incanter.core.Dataset ::dataset)
@@ -1,6 +1,5 @@
-(defproject incanter/incanter-mongodb "1.2.3"
+(defproject incanter/incanter-mongodb "1.3.0-SNAPSHOT"
:description "Incanter-mongodb is the MongoDB module of the Incanter project."
- :dependencies [[incanter/incanter-core "1.2.3"]
- [org.clojars.bmabey/congomongo "0.1.2-SNAPSHOT"]]
- ;[congomongo "0.1.2-SNAPSHOT"]]
+ :dependencies [[incanter/incanter-core "1.3.0-SNAPSHOT"]
+ [congomongo "0.1.7-SNAPSHOT"]]
:dev-dependencies [[lein-clojars "0.6.0"]])
View
@@ -3,12 +3,12 @@
:dependencies [[incanter/incanter-core "1.3.0-SNAPSHOT"]
[incanter/incanter-io "1.3.0-SNAPSHOT"]
[incanter/incanter-charts "1.3.0-SNAPSHOT"]
- [incanter/incanter-processing "1.2.3"]
- [incanter/incanter-mongodb "1.2.3"]
+ [incanter/incanter-processing "1.3.0-SNAPSHOT"]
+ [incanter/incanter-mongodb "1.3.0-SNAPSHOT"]
[incanter/incanter-pdf "1.2.3"]
[incanter/incanter-latex "1.2.3"]
[incanter/incanter-excel "1.2.3"]
- [swingrepl "1.0.0-SNAPSHOT"]
+ [swingrepl "1.3.0"]
[jline "0.9.94"]]
:dev-dependencies [[lein-clojars "0.6.0"]
[swank-clojure "1.3.0-SNAPSHOT"]]

0 comments on commit e6307d6

Please sign in to comment.