Remove Request from Task Repo parameters

AlexKupreev · Jun 9, 2014 · 779eb8ad08e727092a7e652b0ddae2cadbd257ea · 779eb8a
1 parent 96817fa
commit 779eb8ad08e727092a7e652b0ddae2cadbd257ea
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/app/interactor/Task/Creation.php b/app/interactor/Task/Creation.php
@@ -43,7 +43,13 @@ public function __construct(
     public function execute(Request\Task\Creation $request)
     {
         $userId = $this->session->getLoggedInUserId();
-        $this->taskRepo->create(null, $userId, $request);
+        $this->taskRepo->create(
+            null,
+            $userId,
+            $request->getTitle(),
+            $request->getDescription(),
+            $request->getNotes()
+        );
 
         return true;
     }

diff --git a/app/mock/repository/Task.php b/app/mock/repository/Task.php
@@ -21,17 +21,14 @@ class Task implements Repo\TaskInterface
     protected $taskIds = [];
 
     /**
-     * Creates Task entity from a data array
-     * @param int $userId
-     * @param Request\Task\Creation $request
-     * @return Entity\Task
+     * {@inheritDoc}
      */
-    public function create($id, $userId, Request\Task\Creation $request)
+    public function create($id, $userId, $title, $description, $notes)
     {
         if (empty($id) or ! $this->isFreeId($id)) {
             $id = $this->getUniqId();
         }
-        $task = new Entity\Task($id, $userId, $request->getTitle(), $request->getDescription(), $request->getNotes());
+        $task = new Entity\Task($id, $userId, $title, $description, $notes);
         $this->taskIds[] = $task->getId();
 
         return $task;

diff --git a/app/repository/TaskInterface.php b/app/repository/TaskInterface.php
@@ -10,7 +10,11 @@ interface TaskInterface
      * Creates a task from a data array
      * @param int $id
      * @param int $userId
-     * @param Request\Task\Creation $request
+     * @param string $title
+     * @param string $description
+     * @param string $notes
+     * 
+     * @return Entity\Task
      */
-    public function create($id, $userId, Request\Task\Creation $request);
+    public function create($id, $userId, $title, $description, $notes);
 }