treemacs-collect-child-nodes Finds only direct children test failure with Emacs 27.1 (release candidate)

[jackhill]

Hi,

While testing treemacs version 2.8 with the Emacs 27.1 release candidate, I ran into the following test failure:

treemacs-collect-child-nodes
  Finds nothing for last node (0.08ms)
  Finds nothing for node without direct children (0.09ms)
  Finds only direct childre  FAILED (0.12ms)
[…]
treemacs-collect-child-nodes Finds only direct childre

Traceback (most recent call last):
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let*...
  (unwind-protect (progn (let* ((root1 (progn (insert (propertize "Root1" 'b...
  (progn (let* ((root1 (progn (insert (propertize "Root1" 'button t :depth 1...
  (let* ((root1 (progn (insert (propertize "Root1" 'button t :depth 1)) (beg...
  (let* ((result (-map #'treemacs--get-label-of (treemacs-collect-child-node...
  (buttercup-expect (closure ((result) (_child2 . #<marker in no buffer>) (_...
  (buttercup-fail "%s" "Expected `result' to contain the same items as `(\" ...
  (signal buttercup-failed "Expected `result' to contain the same items as `...
FAILED: Expected `result' to contain the same items as `("  Child1" "  Child2")', but `("  Child1" "  Child2")' are missing.

Ran 173 specs, 1 failed, in 0.5 seconds.

[Alexander-Miller]

Investigating.

[Alexander-Miller]

I can't quite remember if I fixed this properly, or if it went away as a side-effect of something else, but seeing how it's no longer reproducible for me I think it's safe to close this issue.