Skip to content

/ DiseaseControl-SPA

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bootstrap, fix react-router #1

Merged
merged 1 commit into from Mar 22, 2020
Merged

feat: add bootstrap, fix react-router #1

merged 1 commit into from Mar 22, 2020

Conversation

@iamandrewluca
Copy link
Collaborator

iamandrewluca commented Mar 22, 2020 •
edited

  • add missing dependencies
  • remove styles that went with default CRA
  • fix react-router usage in App.jsx
  • added better utility for application guard
  • remove redundant div
  • remove redundant Redirect right now
  • add Header and Footer
  • migrate Login to use bootstrap styling
Screenshot

login
@iamandrewluca iamandrewluca requested a review from nicoletailiuha Mar 22, 2020
@iamandrewluca iamandrewluca changed the title fix: fix usage of `react-router` fix: adapted usage of `react-router` Mar 22, 2020
@iamandrewluca iamandrewluca reopened this Mar 22, 2020
@iamandrewluca iamandrewluca changed the title fix: adapted usage of `react-router` wip: fix: adapted usage of `react-router` Mar 22, 2020
@iamandrewluca
feat: add bootstrap, fix react-router
Verified
This commit was signed with a verified signature.
iamandrewluca Andrew Luca
GPG key ID: 8CEE7E0149460DB9 Learn about signing commits
695026a
@iamandrewluca iamandrewluca force-pushed the iamandrewluca:Olga branch from 5eb862c to 695026a Mar 22, 2020
@iamandrewluca iamandrewluca changed the title wip: fix: adapted usage of `react-router` feat: add bootstrap, fix react-router Mar 22, 2020
iamandrewluca referenced this pull request in iamandrewluca/DiseaseControl-SPA Mar 22, 2020
@iamandrewluca
feat: adapt dashboard with bootstrap components and styles
Verified
This commit was signed with a verified signature.
iamandrewluca Andrew Luca
GPG key ID: 8CEE7E0149460DB9 Learn about signing commits
989b4f5 
Depends on #1
@iamandrewluca iamandrewluca mentioned this pull request Mar 22, 2020
Merged
@nicoletailiuha
nicoletailiuha approved these changes Mar 22, 2020
View changes
@nicoletailiuha nicoletailiuha merged commit 95f1535 into AlexanderC:dev Mar 22, 2020
@iamandrewluca iamandrewluca deleted the iamandrewluca:Olga branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoletailiuha nicoletailiuha

Assignees

@iamandrewluca iamandrewluca

@nicoletailiuha nicoletailiuha

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@iamandrewluca @nicoletailiuha
You can’t perform that action at this time.