Changes proposed on freebsd-net@ #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sending an advertisement, free mbuf from packet_mp and NULL it. As was stated in disscussion on freebsd-net@, "freeing mbuf is under pfil hook responsibility, if it returns nonzero value it must call m_freem()". Link: https://lists.freebsd.org/pipermail/freebsd-net/2017-July/048537.html
Citing from disscussion on freebsd-net@: "ip6_output() always consumes mbuf, it is wrong to call m_freem() after calling ip6_output(), even when it returns error". Link: https://lists.freebsd.org/pipermail/freebsd-net/2017-July/048537.html
AlexandreFenyo
approved these changes
Jul 22, 2017
|
Thanks for these patches. For information, I've submited this kernel module to the ports tree in this request: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219622 I'm currently testing the port with poudriere. I will soon make some minor updates due to new warnings (-Waddress-of-packed-member) that appeared with the change from clang 3.8.0 to clang 4.0.0 that occured between FreeBSD 11.0 and 11.1-RC3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disscussed here:
https://lists.freebsd.org/pipermail/freebsd-net/2017-July/048537.html