From d01f1f44ec16866c084f7c792502dc4c3a5c08fa Mon Sep 17 00:00:00 2001 From: Brian Brown Date: Fri, 31 Jul 2026 22:27:44 -0400 Subject: [PATCH] fix(hyprland/workspaces): respect enable-bar-scroll config option Removed hasScrollConfig boolean variable in Workspaces init function. It was Or'd with barScroll boolean variable and overriding it when enable-bar-scroll is declared false in waybar config. Setting any scroll up or down events caused enable-bar-scroll to be overwritten. Tested on Arch/Hyprland, removing hasScrollConfig and the or condition restored expected behavior. Fixes #5229 --- src/modules/hyprland/workspaces.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/hyprland/workspaces.cpp b/src/modules/hyprland/workspaces.cpp index 780e041d8..2e852dc05 100644 --- a/src/modules/hyprland/workspaces.cpp +++ b/src/modules/hyprland/workspaces.cpp @@ -55,8 +55,8 @@ void Workspaces::init() { if (m_scrollEventConnection_.connected()) { m_scrollEventConnection_.disconnect(); } - bool hasScrollConfig = config_["on-scroll-up"].isString() || config_["on-scroll-down"].isString(); - if (barScroll() || hasScrollConfig) { + + if (barScroll()) { auto& window = const_cast(m_bar).window; window.add_events(Gdk::SCROLL_MASK | Gdk::SMOOTH_SCROLL_MASK); m_scrollEventConnection_ =