[cmake] update modules #7891
Merged
[cmake] update modules #7891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the review. |
|
@cenit Hi, why sometimes periodically were some checks not successful in GitHub actions? |
|
there is a bug upstream in vcpkg due to an incompatibility with cmake 3.21 which is being fixed right now it will self-fix automatically in a few days at maximum and all the checks will become green again then (also those that are failing now will re-run and become ok) |
|
@cenit Great! Is this PR ready, and can I merge it? |
|
yes |
juhong-rdv
pushed a commit
to juhong-rdv/darknet
that referenced
this pull request
Dec 18, 2021
* [cmake] update modules * [cmake] use proper module name when using vcpkg libs * apply fixes from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should keep our modules up to date with external libraries updates (see for example an improved compatibility with cuDNN 8)