Change generate_qc_report argument name and update version numbers #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashapiro
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Trusting your testing (which I assume was done with :edge), but noting that this should not go in until the scpcatools 0.1.7 docker image final finishes building: https://github.com/AlexsLemonade/scpcaTools/actions/runs/2436196085
This was referenced Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194.
Here I changed the name for the argument used when calling
scpcaTools::generate_qc_report()to reflect the new argument,library_id. I tested this and all looked good and produced a QC report as expected for a multiplexed library.I also am changing the version of
scpcaToolsthat we are using to v0.1.7 and then updating the version forscpca-nfto v0.3.2 to prepare for the new release.