New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the way the list of quran translations is generated #498

Open
assem-ch opened this Issue May 26, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@assem-ch
Copy link
Member

assem-ch commented May 26, 2018

Current behavior, the translations file should be always there since its main resource.. after indexing translations, we run update_translations_indexed_list to get all translations from index and store them in the translation file. current problems involve that the file is essential and also should be tracked , and the operation of listing is very slow.

Right behavior, no file should be by default, if no file the list should be considered as empty dictionary. Translations should be added in the indexing phase not after indexing:

  • Index translation x,
  • If success, add translation x to translations.json
  • First translation indexed should create the file

@assem-ch assem-ch added bug enhancement and removed bug labels May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment