New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate project to support python 3 #515

Open
delassio opened this Issue Jan 7, 2019 · 9 comments

Comments

Projects
None yet
2 participants
@delassio
Copy link

delassio commented Jan 7, 2019

Salam Alaikoum,

Hello, how about making this project supporting python 3

Thanks

@assem-ch

This comment has been minimized.

Copy link
Member

assem-ch commented Jan 7, 2019

@delassio Salam, migration will cost lot of efforts so if there is no clear advantage to have python 3, it will be probably a bad idea

@delassio

This comment has been minimized.

Copy link
Author

delassio commented Jan 8, 2019

hello, thank you her is the motivation:
"Being the last of the 2.x series, 2.7 will have an extended period of maintenance. Specifically, 2.7 will receive bugfix support until January 1, 2020. After the last release, 2.7 will receive no support."
https://python3statement.org/
https://www.python.org/dev/peps/pep-0373/#update
https://www.python.org/dev/peps/pep-0373/#maintenance-releases

B.R

@assem-ch

This comment has been minimized.

Copy link
Member

assem-ch commented Jan 10, 2019

@delassio the issue is in the used whoosh library included in the support folder, the project should upgraded to use the last version of whoosh, even if there will be broken features. After that it can easily updated to support python 3.

Another solution is to refactor the project to use elastic search instead of whoosh, and focus only on web.

@delassio

This comment has been minimized.

Copy link
Author

delassio commented Jan 10, 2019

sorry, where i can found the support folder

@assem-ch

This comment has been minimized.

@delassio

This comment has been minimized.

Copy link
Author

delassio commented Jan 13, 2019

Hello,

so we need to upgrade whoosh from 0.3.18 to 2.7

B.R

@assem-ch

This comment has been minimized.

Copy link
Member

assem-ch commented Jan 14, 2019

@delassio Yes, that's it, even if this involve sacrificing some features

@delassio

This comment has been minimized.

Copy link
Author

delassio commented Jan 14, 2019

good do you have roadmap (backlog) to do that

@assem-ch

This comment has been minimized.

Copy link
Member

assem-ch commented Jan 14, 2019

@delassio first you force version to the last version of whoosh, then fix any thing that get broken, if something is changed too much, rewrite it or eliminate it (no choice)

The subtasks will rise when you force the version but for now we only can guess it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment