Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8158] Resolved issue where long tag names were not getting word wrapped in ACA. Fixed alignment issue with tag chip cross button #3890

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

swapnil-verma-gl
Copy link
Contributor

@swapnil-verma-gl swapnil-verma-gl commented Jun 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Long tag names were not getting word wrapped in ACA after angular upgrade. Tag delete X button was also misaligned

What is the new behaviour?
Long tag names are now word wrapped. Fixed alignment of X button

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://hyland.atlassian.net/browse/ACS-8158.
See also, PR in ADF - Alfresco/alfresco-ng2-components#9808

…wrapped in ACA. Fixed alignment issue with tag chip cross button
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@swapnil-verma-gl swapnil-verma-gl merged commit dc28bcf into ng15-migration Jun 14, 2024
2 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the dev-acs-8158-fix-tag-spacing branch June 14, 2024 04:20
MichalKinas pushed a commit that referenced this pull request Jul 19, 2024
…wrapped in ACA. Fixed alignment issue with tag chip cross button (#3890)
MichalKinas pushed a commit that referenced this pull request Jul 19, 2024
…wrapped in ACA. Fixed alignment issue with tag chip cross button (#3890)
MichalKinas added a commit that referenced this pull request Jul 22, 2024
* [ACS-6693] Angular 15 migration initial point

* [ACS-6693] Angular 15 - update ADF dependencies from the ng15-start branch (#3712)

* [ACS-6693] Angular 15 - adding mat core (#3715)

* Stylelint fix

* Migration - added stylePrepocessor for material selectors

* Skip unit tests from branch release until errors are fixed

* [ACS-7285] - [ACA] Angular 15 - Left sidebar + table (#3719)

* [ACS-7286] Fix topbar user info issues (#3720)

* [ACS-6693] Bump peerDependencies in ACA libs

* [ACS-7330] edit rules dialog fixes (#3723)

* [ACS-6693] Fix peer dependencies in ACA packages

* [ACS-7328] Fix searchbar display (#3729)

* [ACS-7631] Fix broken filters (#3735)

* [ACS-7331] - Angular 15 - Edit aspects modal [ACA]

* [ACS-7449] Fix broken filter labels styling (#3745)

* [ACS-7351] ng15 Manage rules fixes (#3751)

* [ACS-7351] ng15 manage rules fixes

* [ACS-7351] cr fix

* [ACS-7351] cr fix

* [ACS-7370] - [ACA] Leave library dialog misses some padding (#3749)

* [ACS-6693] Bump ADF version

* [ACS-7372] - user profile page issues (#3757)

* [ACS-7372] - [ACA] User profile page issues

* [ACS-7415] - Move file dialog (#3755)

* [ACS-7452] - Small screen notification banner [ACS-7418] About page (#3760)

* [ACS-7452] - Small screen notification banner

* [ACS-7452] - Small screen notification banner [ACS-7418] About page

* [ACS-7511] Subfont for dialogs, make darker (#3765)

* [ACS-7448] Fix wrong notifications colors (#3761)

* [ACS-7448] Fix notifications colors, move them from adf to aca (#3771)

* [ACS-7375] - Share link dialog issues (#3774)

* [ACS-7517] - Notifications box (#3775)

* [ACS-7373] ng15 permission tab fixes (#3762)

* [ACS-7368] Fix unit tests for aca-content (#3779)

* [ACS-7410] - Locked files overflow issues (#3780)

* [ACS-7528] - Notification and user icons are a bit different (#3782)

* [ACS-7529] - Columns visibility dropdown has broken styles (#3783)

* [ACS-7537] - Share dialog (#3789)

* Use latest ADF alpha

* Post rebase unit test fix

* Disable stylelint

* Calendar button fix

* [ACS-7369] ng15 migration - fix e2es (#3796)

* [ACS-7369] e2e fixes

* [ACS-7369] cr fix

* [ACS-7331] - Angular 15 - View details sidebar (#3731)

* [ACS-7542] - Upload new version dialog (#3800)

* [ACS-7575] create library dialog e2e fix (#3803)

* [ACS-7534] folder dialog e2e fixes (#3804)

* [ACS-7574] Rules dialog edit (#3801)

* [ACS-7571] Comments (#3810)

* [ACS-7555] Added blue outline to focused checkboxes (#3813)

* [ACS-7582] File upload dialog, fix button weight label globally (#3814)

* [ACS-7531] - Search page (#3816)

* [ACS-7559] Conext menus icons (#3818)

* [ACS-6693] Bump ADF

* Temporary lint disable

* [ACS-7572] link rules dialog (#3817)

* [ACS-7533] - Advanced search chips dropdowns (#3821)

* [ACS-7560] Corrected background color for info snackbar (#3824)

* [ACS-7558] - Toolbar and buttons (#3833)

* [ACS-7573] folder rules fixes (#3836)

* [ACS-7573] folder rules fixes

* [ACS-7573] cr fix

* [ACS-7561] - Permissions page (#3840)

* [ACS-7768] unify inputs and selects across the app (#3845)

* ACS-7768 Style inputs in create from template dialog

* ACS-7768 Used globally configured outline appearance for inputs

* ACS-7768 Style inputs for profile page

* ACS-7768 Style inputs for library metadata form

* ACS-7768 Style inputs for folder rules dialog

* ACS-7768 Style inputs for manage rules page

* ACS-7768 Set outline appearance for input, fix small issue

* ACS-7768 Addressed comment

* Revert "[ACS-7768] unify inputs and selects across the app (#3845)" (#3850)

This reverts commit 6a5ef73.

* [ACS-8043] fix js api dependencies (#3855)

* [ACS-8020] Fixed inputs for create from template dialog (#3857)

* [ACS-8027] Inputs for create rules (#3860)

* [ACS-8052] inputs for general info for libraries (#3863)

* [ACS-8052] Inputs for general info for libraries

* Fix after CR

* [ACS-8059] Inputs for view rules (#3865)

* [ACS-8026] Fixed Task form rendering (#3864)

* Updating to the latest package of 6.10 from ADF

* Updating to the latest ADF/JS-API - updating dependency rule

* Regenerated package lock

* [ACS-8082] fix search e2e (#3876)

* Using latest ADF with BC of ConfirmDialogComponent

* [ACS-8099] [ACA] Testing Angular 15 - Accessibility for search text area (#3883)

* [ACS-8100] [ACA] Testing Angular 15 - Accessibility for search facet and filter (#3887)

* [ACS-8158] Resolved issue where long tag names were not getting word wrapped in ACA. Fixed alignment issue with tag chip cross button (#3890)

* [ACS-8101] [ACA] Testing Angular 15 - Manage rule popup visual changes (#3891)

* [ACS-8191] Updated codebase to use variables from mat-selectors.scss file (#3889)

* [ACS-8191] Updated ACA codebase to use selectors from mat-selectors.scss file instead of hardcoded selectors

* [ACS-8191] Resolved configuration issue where running unit test on aca-shared failed due to not finding adf-core styles

* Update ADF dependencies (#3897)

* Upgrading ADF packages

* Use latest ADF

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* [ACS-8253] viewer file name change position on navigation (#3914)

* Updated ADF version

* Use latest ADF

* Package lock fix

* Build fix

* Restore release branch build and unit tests

* E2Es fix

* Fix SonarCloud issues

* Stylelint fix

* Stylelint fix

* [ACS-8442] Remove additional checkbox label

* First batch of E2E fixes

* Bump ADF

* Second round of E2E locators fixes

* Locator fix

* [ACS-8443] Fix incorrect focus style for checkboxes

* E2Es locators fixes

* E2E locator fixes

* [ACS-6693] locator fix upload new version title

* E2E locator fix

* E2E locator fix

* [ACS-6693] locator fix upload new version file

---------

Co-authored-by: jacekpluta <73617938+jacekpluta@users.noreply.github.com>
Co-authored-by: Vito Albano <vito.albano@hyland.com>
Co-authored-by: tomson <nastalytomasz@gmail.com>
Co-authored-by: Mykyta Maliarchuk <84377976+nikita-web-ua@users.noreply.github.com>
Co-authored-by: Jacek Pluta <jacek.pluta@hyland.com>
Co-authored-by: dominikiwanekhyland <141320833+dominikiwanekhyland@users.noreply.github.com>
Co-authored-by: tomson <tomasz.nastaly@hyland.com>
Co-authored-by: AleksanderSklorz <115619721+AleksanderSklorz@users.noreply.github.com>
Co-authored-by: swapnil-verma-gl <92505353+swapnil-verma-gl@users.noreply.github.com>
Co-authored-by: VitoAlbano <vito.albano.123@gmail.com>
Co-authored-by: Akash Rathod <41251473+akashrathod28@users.noreply.github.com>
Co-authored-by: Ehsan Rezaei <ehsan.rezaei@hyland.com>
Co-authored-by: akash.rathod@hyland.com <akash.rathod@hyland.com>
akashrathod28 added a commit that referenced this pull request Jul 24, 2024
* [ACS-6693] Angular 15 migration initial point

* [ACS-6693] Angular 15 - update ADF dependencies from the ng15-start branch (#3712)

* [ACS-6693] Angular 15 - adding mat core (#3715)

* Stylelint fix

* Migration - added stylePrepocessor for material selectors

* Skip unit tests from branch release until errors are fixed

* [ACS-7285] - [ACA] Angular 15 - Left sidebar + table (#3719)

* [ACS-7286] Fix topbar user info issues (#3720)

* [ACS-6693] Bump peerDependencies in ACA libs

* [ACS-7330] edit rules dialog fixes (#3723)

* [ACS-6693] Fix peer dependencies in ACA packages

* [ACS-7328] Fix searchbar display (#3729)

* [ACS-7631] Fix broken filters (#3735)

* [ACS-7331] - Angular 15 - Edit aspects modal [ACA]

* [ACS-7449] Fix broken filter labels styling (#3745)

* [ACS-7351] ng15 Manage rules fixes (#3751)

* [ACS-7351] ng15 manage rules fixes

* [ACS-7351] cr fix

* [ACS-7351] cr fix

* [ACS-7370] - [ACA] Leave library dialog misses some padding (#3749)

* [ACS-6693] Bump ADF version

* [ACS-7372] - user profile page issues (#3757)

* [ACS-7372] - [ACA] User profile page issues

* [ACS-7415] - Move file dialog (#3755)

* [ACS-7452] - Small screen notification banner [ACS-7418] About page (#3760)

* [ACS-7452] - Small screen notification banner

* [ACS-7452] - Small screen notification banner [ACS-7418] About page

* [ACS-7511] Subfont for dialogs, make darker (#3765)

* [ACS-7448] Fix wrong notifications colors (#3761)

* [ACS-7448] Fix notifications colors, move them from adf to aca (#3771)

* [ACS-7375] - Share link dialog issues (#3774)

* [ACS-7517] - Notifications box (#3775)

* [ACS-7373] ng15 permission tab fixes (#3762)

* [ACS-7368] Fix unit tests for aca-content (#3779)

* [ACS-7410] - Locked files overflow issues (#3780)

* [ACS-7528] - Notification and user icons are a bit different (#3782)

* [ACS-7529] - Columns visibility dropdown has broken styles (#3783)

* [ACS-7537] - Share dialog (#3789)

* Use latest ADF alpha

* Post rebase unit test fix

* Disable stylelint

* Calendar button fix

* [ACS-7369] ng15 migration - fix e2es (#3796)

* [ACS-7369] e2e fixes

* [ACS-7369] cr fix

* [ACS-7331] - Angular 15 - View details sidebar (#3731)

* [ACS-7542] - Upload new version dialog (#3800)

* [ACS-7575] create library dialog e2e fix (#3803)

* [ACS-7534] folder dialog e2e fixes (#3804)

* [ACS-7574] Rules dialog edit (#3801)

* [ACS-7571] Comments (#3810)

* [ACS-7555] Added blue outline to focused checkboxes (#3813)

* [ACS-7582] File upload dialog, fix button weight label globally (#3814)

* [ACS-7531] - Search page (#3816)

* [ACS-7559] Conext menus icons (#3818)

* [ACS-6693] Bump ADF

* Temporary lint disable

* [ACS-7572] link rules dialog (#3817)

* [ACS-7533] - Advanced search chips dropdowns (#3821)

* [ACS-7560] Corrected background color for info snackbar (#3824)

* [ACS-7558] - Toolbar and buttons (#3833)

* [ACS-7573] folder rules fixes (#3836)

* [ACS-7573] folder rules fixes

* [ACS-7573] cr fix

* [ACS-7561] - Permissions page (#3840)

* [ACS-7768] unify inputs and selects across the app (#3845)

* ACS-7768 Style inputs in create from template dialog

* ACS-7768 Used globally configured outline appearance for inputs

* ACS-7768 Style inputs for profile page

* ACS-7768 Style inputs for library metadata form

* ACS-7768 Style inputs for folder rules dialog

* ACS-7768 Style inputs for manage rules page

* ACS-7768 Set outline appearance for input, fix small issue

* ACS-7768 Addressed comment

* Revert "[ACS-7768] unify inputs and selects across the app (#3845)" (#3850)

This reverts commit 6a5ef73.

* [ACS-8043] fix js api dependencies (#3855)

* [ACS-8020] Fixed inputs for create from template dialog (#3857)

* [ACS-8027] Inputs for create rules (#3860)

* [ACS-8052] inputs for general info for libraries (#3863)

* [ACS-8052] Inputs for general info for libraries

* Fix after CR

* [ACS-8059] Inputs for view rules (#3865)

* [ACS-8026] Fixed Task form rendering (#3864)

* Updating to the latest package of 6.10 from ADF

* Updating to the latest ADF/JS-API - updating dependency rule

* Regenerated package lock

* [ACS-8082] fix search e2e (#3876)

* Using latest ADF with BC of ConfirmDialogComponent

* [ACS-8099] [ACA] Testing Angular 15 - Accessibility for search text area (#3883)

* [ACS-8100] [ACA] Testing Angular 15 - Accessibility for search facet and filter (#3887)

* [ACS-8158] Resolved issue where long tag names were not getting word wrapped in ACA. Fixed alignment issue with tag chip cross button (#3890)

* [ACS-8101] [ACA] Testing Angular 15 - Manage rule popup visual changes (#3891)

* [ACS-8191] Updated codebase to use variables from mat-selectors.scss file (#3889)

* [ACS-8191] Updated ACA codebase to use selectors from mat-selectors.scss file instead of hardcoded selectors

* [ACS-8191] Resolved configuration issue where running unit test on aca-shared failed due to not finding adf-core styles

* Update ADF dependencies (#3897)

* Upgrading ADF packages

* Use latest ADF

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* Updated packages version

* [ACS-8253] viewer file name change position on navigation (#3914)

* Updated ADF version

* Use latest ADF

* Package lock fix

* Build fix

* Restore release branch build and unit tests

* E2Es fix

* Fix SonarCloud issues

* Stylelint fix

* Stylelint fix

* [ACS-8442] Remove additional checkbox label

* First batch of E2E fixes

* Bump ADF

* Second round of E2E locators fixes

* Locator fix

* [ACS-8443] Fix incorrect focus style for checkboxes

* E2Es locators fixes

* E2E locator fixes

* [ACS-6693] locator fix upload new version title

* E2E locator fix

* E2E locator fix

* [ACS-6693] locator fix upload new version file

---------

Co-authored-by: jacekpluta <73617938+jacekpluta@users.noreply.github.com>
Co-authored-by: Vito Albano <vito.albano@hyland.com>
Co-authored-by: tomson <nastalytomasz@gmail.com>
Co-authored-by: Mykyta Maliarchuk <84377976+nikita-web-ua@users.noreply.github.com>
Co-authored-by: Jacek Pluta <jacek.pluta@hyland.com>
Co-authored-by: dominikiwanekhyland <141320833+dominikiwanekhyland@users.noreply.github.com>
Co-authored-by: tomson <tomasz.nastaly@hyland.com>
Co-authored-by: AleksanderSklorz <115619721+AleksanderSklorz@users.noreply.github.com>
Co-authored-by: swapnil-verma-gl <92505353+swapnil-verma-gl@users.noreply.github.com>
Co-authored-by: VitoAlbano <vito.albano.123@gmail.com>
Co-authored-by: Akash Rathod <41251473+akashrathod28@users.noreply.github.com>
Co-authored-by: Ehsan Rezaei <ehsan.rezaei@hyland.com>
Co-authored-by: akash.rathod@hyland.com <akash.rathod@hyland.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants