From 1d4caef2694ed97fb226d429cfb92af38fcf632b Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Mon, 13 May 2024 11:20:20 -0400 Subject: [PATCH] cleanup tasklist service api [ci:force] --- .../task-list/services/tasklist.service.ts | 24 ++++--------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/lib/process-services/src/lib/task-list/services/tasklist.service.ts b/lib/process-services/src/lib/task-list/services/tasklist.service.ts index 0322835651..81d56a6b2b 100644 --- a/lib/process-services/src/lib/task-list/services/tasklist.service.ts +++ b/lib/process-services/src/lib/task-list/services/tasklist.service.ts @@ -71,8 +71,8 @@ export class TaskListService { */ getFilterForTaskById(taskId: string, filterList: FilterRepresentationModel[]): Observable { return from(filterList).pipe( - flatMap((data: FilterRepresentationModel) => this.isTaskRelatedToFilter(taskId, data)), - filter((data: FilterRepresentationModel) => data != null) + flatMap((data) => this.isTaskRelatedToFilter(taskId, data)), + filter((data) => data != null) ); } @@ -155,15 +155,7 @@ export class TaskListService { * @returns Array of checklist task details */ getTaskChecklist(id: string): Observable { - return from(this.checklistsApi.getChecklist(id)).pipe( - map((response) => { - const checklists: TaskDetailsModel[] = []; - response.data.forEach((checklist) => { - checklists.push(new TaskDetailsModel(checklist)); - }); - return checklists; - }) - ); + return from(this.checklistsApi.getChecklist(id)).pipe(map((response) => response.data.map((checklist) => new TaskDetailsModel(checklist)))); } /** @@ -178,15 +170,7 @@ export class TaskListService { modelType: 2 // Integer | modelType }; - return from(this.modelsApi.getModels(opts)).pipe( - map((response) => { - const forms: Form[] = []; - response.data.forEach((form) => { - forms.push(new Form(form.id, form.name)); - }); - return forms; - }) - ); + return from(this.modelsApi.getModels(opts)).pipe(map((response) => response.data.map((form) => new Form(form.id, form.name)))); } /**