From dbb7aeff8eac7c9c89fb8fd0e55f63f6778ff7b2 Mon Sep 17 00:00:00 2001 From: Ketevani Kvirikashvili Date: Mon, 29 Nov 2021 12:26:09 +0200 Subject: [PATCH] [AAE-6307] Setting a default process name (#7389) * [AAE-6307] Setting a process name on init if process definition name is present * delete space and adding semicolon * fixed lint --- .../start-process-cloud.component.spec.ts | 13 +++++++++++++ .../components/start-process-cloud.component.ts | 16 +++++++++++----- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts b/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts index 3b884046193..ea8fed5f0d0 100755 --- a/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts +++ b/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.spec.ts @@ -827,6 +827,19 @@ describe('StartProcessCloudComponent', () => { expect(component.processInstanceName.value).toEqual('fake-transformed-name'); }); + it('should set the process name on init when a process definition name is present', () => { + const processNameCloudPipe = TestBed.inject(ProcessNameCloudPipe); + const fakeTransformedName = 'fake-transformed-name'; + spyOn(processNameCloudPipe, 'transform').and.returnValue(fakeTransformedName); + + component.processDefinitionName = 'fake-name'; + component.ngOnInit(); + + expect(component.processInstanceName.dirty).toBe(true); + expect(component.processInstanceName.touched).toBe(true); + expect(component.processInstanceName.value).toEqual(fakeTransformedName); + }); + it('should cancel bubbling a keydown event ()', () => { const escapeKeyboardEvent = new KeyboardEvent('keydown', { 'keyCode': ESCAPE } as any); fixture.debugElement.triggerEventHandler('keydown', escapeKeyboardEvent); diff --git a/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts b/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts index 14ecd04dc10..7f73e93c213 100755 --- a/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts +++ b/lib/process-services-cloud/src/lib/process/start-process/components/start-process-cloud.component.ts @@ -144,6 +144,8 @@ export class StartProcessCloudComponent implements OnChanges, OnInit, OnDestroy this.processDefinition.setValue(this.processDefinitionName); this.processDefinition.markAsDirty(); this.processDefinition.markAsTouched(); + + this.setDefaultProcessName(this.processDefinitionName); } } @@ -384,15 +386,19 @@ export class StartProcessCloudComponent implements OnChanges, OnInit, OnDestroy processDefinitionSelectionChanged(processDefinition: ProcessDefinitionCloud) { if (processDefinition) { - const processInstanceDetails: ProcessInstanceCloud = { processDefinitionName: processDefinition.name }; - const defaultProcessName = this.processNameCloudPipe.transform(this.name, processInstanceDetails); - this.processInstanceName.setValue(defaultProcessName); - this.processInstanceName.markAsDirty(); - this.processInstanceName.markAsTouched(); + this.setDefaultProcessName(processDefinition.name); this.processDefinitionSelection.emit(processDefinition); } } + setDefaultProcessName(processDefinitionName: string): void { + const processInstanceDetails: ProcessInstanceCloud = { processDefinitionName }; + const defaultProcessName = this.processNameCloudPipe.transform(this.name, processInstanceDetails); + this.processInstanceName.setValue(defaultProcessName); + this.processInstanceName.markAsDirty(); + this.processInstanceName.markAsTouched(); + } + ngOnDestroy() { this.onDestroy$.next(true); this.onDestroy$.complete();