Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of search facets #3270

Closed
kaspereden opened this issue May 4, 2018 · 5 comments
Closed

Translation of search facets #3270

kaspereden opened this issue May 4, 2018 · 5 comments
Assignees
Milestone

Comments

@kaspereden
Copy link
Contributor

I am not really sure whether or not this is a bug or feature request. But for our clients localization is really a big thing. Literally everything must be in Dutch.

Type of issue: (check with "[x]")

  • New feature request
  • Bug
  • Support request
  • Documentation

Current behaviour:
The search filter component has the option to set some of the labels in the app.config.json. Only the ones on the top level are being translated. The rest is not. Also titles like "Facet Queries" cannot be translated. (https://github.com/Alfresco/alfresco-ng2-components/blob/master/lib/content-services/search/components/search-filter/search-filter.component.html#L22)

I am having config like this:

{
          "id": "queryType",
          "name": "SEARCH.TYPE.LABEL",
          "enabled": true,
          "expanded": false,
          "component": {
            "selector": "adf-search-radio",
            "settings": {
              "field": null,
              "options": [
                {
                  "name": "SEARCH.TYPE.OPTIONS.NONE",
                  "value": "",
                  "default": true
                },
                {
                  "name": "SEARCH.TYPE.OPTIONS.ALL",
                  "value": "TYPE:'cm:folder' OR TYPE:'cm:content'"
                },
                {
                  "name": "SEARCH.TYPE.OPTIONS.FOLDER",
                  "value": "TYPE:'cm:folder'"
                },
                {
                  "name": "SEARCH.TYPE.OPTIONS.DOCUMENT",
                  "value": "TYPE:'cm:content'"
                }
              ]
            }
          }
        },

Which results in this:
image

Expected behavior:
Expected that all labels could be translated.

Steps to reproduce the issue:
Implement i18n and search facets. Copy the config from above and it will result in the same.

Component name and version:
search-module and all its child components.

Browser and version:
all

Node version (for build issues):
v9.4.0

New feature request:

@DenysVuika DenysVuika self-assigned this May 4, 2018
@DenysVuika
Copy link
Contributor

Thanks for pointing out. We are working on the full i18n support for faceted search widgets at the moment. I will ensure check/radio lists support that.

@kaspereden
Copy link
Contributor Author

Also lists and so. :)

@eromano
Copy link
Contributor

eromano commented May 4, 2018

@kaspereden could be some missing string in the translate files , we are going to give a look but it will be fixed in the next version if is a bug. For now you can add the keys in your local i18n files of your app
as workaround

@eromano
Copy link
Contributor

eromano commented May 4, 2018

@DenysVuika
Copy link
Contributor

It is definitely a bug for radio widget. But we will review entire i18n support for the next release. Everything is going to be translatable.

@DenysVuika DenysVuika added this to the 2.4.0 milestone May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants