New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pageSize value fetch for infinite pagination #4073

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@nbarithel
Copy link
Contributor

nbarithel commented Dec 11, 2018

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
pageSize of 25 is always used

What is the new behaviour?
uses pageSize defined on the component or by the UserPreferencesService
if not defined

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/ADF-3843

Fix pageSize value fetch for infinite pagination
- uses pageSize defined on the component or by the UserPreferencesService
if not defined
@eromano

This comment has been minimized.

Copy link
Contributor

eromano commented Dec 13, 2018

@nbarithel thanks for your contribution! It makes sense to me your modify

@eromano eromano merged commit 4111666 into Alfresco:development Dec 13, 2018

9 of 10 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - demo-shell/package.json (eromano) No new issues
Details
security/snyk - lib/content-services/package.json (eromano) No new issues
Details
security/snyk - lib/core/package.json (eromano) No new issues
Details
security/snyk - lib/extensions/package.json (eromano) No new issues
Details
security/snyk - lib/insights/package.json (eromano) No new issues
Details
security/snyk - lib/process-services/package.json (eromano) No new issues
Details
security/snyk - package.json (eromano) No new issues
Details

@eromano eromano added this to the 3.0.0 milestone Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment