New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate noSnapshotVersion logic, as upstream https://issues.alfresco.com/jira/browse/ACE-2269 was fixed #294

Closed
mindthegab opened this Issue May 27, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@mindthegab
Contributor

mindthegab commented May 27, 2015

https://issues.alfresco.com/jira/browse/ACE-2269 was fixed in 5.0.0. This means Alfresco will accept -SNAPSHOT as a module version.

This will allow to remove the "hack" we currently do in the SDK to produce a noSnapshotVersion of the module.

I suggest we just use -SNAPSHOT during module development, with maybe an option to append / replace with an incremental version number (i.e. maybe leave the current logic in place, but make -SNAPSHOT the default and instead allow people to manually configure if they want moduleIncrementalSnapshotVersioning)

@mindthegab mindthegab added this to the 2.1.1 milestone May 27, 2015

@rgauss

This comment has been minimized.

Show comment
Hide comment
@rgauss

rgauss May 27, 2015

Member

Is support of 4.2 still a goal of the alfresco-sdk?

Member

rgauss commented May 27, 2015

Is support of 4.2 still a goal of the alfresco-sdk?

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab May 27, 2015

Contributor

@rgauss Yes, as per http://docstest.alfresco.com/5.0/concepts/alfresco-sdk-compatibility.html and, 1.1.1 is compatible with 4.2, while 2.0.0 and 2.1.0 with 5.x.

And, per http://www.alfresco.com/services/subscription/technical-support/product-support-status, 4.2.Latest is still in full support, so yes we need to provide an SDK for it.

1.1.1. is what works with 4.2, but obviously it has no hot reloading support. @ohej had started working on backporting 2.0.0 features into a 1.2.0, and did some work at DevCon hackathon last year that resulted in a 1.2.0-SNAPSHOT (see https://oss.sonatype.org/#nexus-search;gav~org.alfresco.maven~~1.2.0-SNAPSHOT~~), but we never did a final release. We are picking this back up and plan to do a 1.2.0 release based off new features on 2.1.0.

Makes sense?

Contributor

mindthegab commented May 27, 2015

@rgauss Yes, as per http://docstest.alfresco.com/5.0/concepts/alfresco-sdk-compatibility.html and, 1.1.1 is compatible with 4.2, while 2.0.0 and 2.1.0 with 5.x.

And, per http://www.alfresco.com/services/subscription/technical-support/product-support-status, 4.2.Latest is still in full support, so yes we need to provide an SDK for it.

1.1.1. is what works with 4.2, but obviously it has no hot reloading support. @ohej had started working on backporting 2.0.0 features into a 1.2.0, and did some work at DevCon hackathon last year that resulted in a 1.2.0-SNAPSHOT (see https://oss.sonatype.org/#nexus-search;gav~org.alfresco.maven~~1.2.0-SNAPSHOT~~), but we never did a final release. We are picking this back up and plan to do a 1.2.0 release based off new features on 2.1.0.

Makes sense?

@rgauss

This comment has been minimized.

Show comment
Hide comment
@rgauss

rgauss May 27, 2015

Member

Yes, we just need to be sure this particular issue stays only on the SDK 2.x code line as ACE-2269 does not apply to Alfresco One 4.2.x.

Member

rgauss commented May 27, 2015

Yes, we just need to be sure this particular issue stays only on the SDK 2.x code line as ACE-2269 does not apply to Alfresco One 4.2.x.

@mindthegab mindthegab modified the milestones: 2.2.0, 2.1.1 Aug 6, 2015

@mindthegab mindthegab modified the milestones: 3.0.0, 2.2.0 Oct 28, 2015

@gravitonian gravitonian modified the milestones: 2.2.0, 3.0.0 Jan 21, 2016

@gravitonian gravitonian self-assigned this Jan 21, 2016

@gravitonian

This comment has been minimized.

Show comment
Hide comment
@gravitonian
Contributor

gravitonian commented Jan 21, 2016

@gravitonian

This comment has been minimized.

Show comment
Hide comment
@gravitonian

gravitonian Jan 22, 2016

Contributor

Fixed

Contributor

gravitonian commented Jan 22, 2016

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment