New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect naming for generated amp modules #311

Closed
bhagyas opened this Issue Jun 18, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@bhagyas
Contributor

bhagyas commented Jun 18, 2015

  1. Generate a project using the archetype.
  2. Compile the project.
  3. Check module name in target/repo/WEB-INF/classes/alfresco/module

In step 3, module name says repo-amp.

This introduces issues when creating a combined project with two or more maven archetype generated projects.

@bhagyas

This comment has been minimized.

Show comment
Hide comment
@bhagyas

bhagyas Jun 18, 2015

Contributor

Related to #312

Contributor

bhagyas commented Jun 18, 2015

Related to #312

@mindthegab

This comment has been minimized.

Show comment
Hide comment
@mindthegab

mindthegab Aug 6, 2015

Contributor

Is this also a dupe of #278 ?

@ohej Can you please make some clarity between #278 , #312 , #311 and the pull request #316 ?

Contributor

mindthegab commented Aug 6, 2015

Is this also a dupe of #278 ?

@ohej Can you please make some clarity between #278 , #312 , #311 and the pull request #316 ?

@gravitonian gravitonian assigned gravitonian and unassigned ohej Oct 5, 2015

@gravitonian gravitonian closed this Oct 7, 2015

ohej added a commit that referenced this issue Oct 9, 2015

Revert "DEVPLAT-338, Incorrect naming of AIO AMPs, #311"
This reverts commit 6c57d9e.

We can't put this commit in a SP release, so we have to revert the revert when we need it back

@ohej ohej modified the milestones: 3.0.0, 2.1.1 Oct 9, 2015

@ohej

This comment has been minimized.

Show comment
Hide comment
@ohej

ohej Oct 9, 2015

Collaborator

We had to revert the change since we can't have this substantial changes in a minor release. When we want the change to go in, we simply have to "revert the revert" like this:
git revert b2afebed09befcbbe1214d056b6f976da5303968

Collaborator

ohej commented Oct 9, 2015

We had to revert the change since we can't have this substantial changes in a minor release. When we want the change to go in, we simply have to "revert the revert" like this:
git revert b2afebed09befcbbe1214d056b6f976da5303968

@ohej ohej reopened this Oct 9, 2015

ohej added a commit that referenced this issue Nov 6, 2015

@ohej

This comment has been minimized.

Show comment
Hide comment
@ohej

ohej Nov 6, 2015

Collaborator

I have reverted the revert so this will be in the next release

Collaborator

ohej commented Nov 6, 2015

I have reverted the revert so this will be in the next release

@ohej ohej closed this Nov 6, 2015

@gravitonian gravitonian modified the milestones: 2.2.0, 3.0.0 Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment