New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service-context.xml to use filterable property for moduleId rather than bare reference #364

Closed
binduwavell opened this Issue Feb 29, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@binduwavell
Collaborator

binduwavell commented Feb 29, 2016

When creating an AIO project from the 2.2.0-SNAPSHOT SDK, demo-repo-amp/src/main/amp/config/alfresco/module/demo-repo-amp/context/service-context.xml has a bare value for moduleId rather than a filterable property like ${project.artifactId}, which is what we have in module.properties.

Since part of the 2.2.0 SDK is create clearer artifactIds for our projects, we likely should reference the filterable property so that we reduce the number of steps required to rename the artifactId manually after the project is created.

@gravitonian gravitonian added this to the 2.2.0 milestone Feb 29, 2016

@gravitonian gravitonian self-assigned this Feb 29, 2016

gravitonian pushed a commit that referenced this issue Feb 29, 2016

@gravitonian

This comment has been minimized.

Show comment
Hide comment
@gravitonian

gravitonian Feb 29, 2016

Contributor

Fixed

Contributor

gravitonian commented Feb 29, 2016

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment