New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK3 No minification #423

Open
wrighting opened this Issue Oct 26, 2016 · 7 comments

Comments

Projects
None yet
6 participants
@wrighting

wrighting commented Oct 26, 2016

You used to get myfile-min.js etc, you don't now

@gravitonian gravitonian added this to the 3.0.0 milestone Oct 26, 2016

@gravitonian gravitonian self-assigned this Oct 26, 2016

@jgoldhammer

This comment has been minimized.

Show comment
Hide comment
@jgoldhammer

jgoldhammer Nov 26, 2016

Collaborator

Please describe in detail what does not work. Do you want to say that the SDK 3 does not minify your javascript files when building an war-file? Or anything else?

Thanks
Jens

Collaborator

jgoldhammer commented Nov 26, 2016

Please describe in detail what does not work. Do you want to say that the SDK 3 does not minify your javascript files when building an war-file? Or anything else?

Thanks
Jens

@gravitonian

This comment has been minimized.

Show comment
Hide comment
@gravitonian

gravitonian Nov 28, 2016

Contributor

I think it might be that we just have to add the maven plugin for it, like in SDK 2.2.0 projects:

<!-- Compress JavaScript files and store as *-min.js --> <plugin> <groupId>net.alchim31.maven</groupId> <artifactId>yuicompressor-maven-plugin</artifactId> </plugin>

Contributor

gravitonian commented Nov 28, 2016

I think it might be that we just have to add the maven plugin for it, like in SDK 2.2.0 projects:

<!-- Compress JavaScript files and store as *-min.js --> <plugin> <groupId>net.alchim31.maven</groupId> <artifactId>yuicompressor-maven-plugin</artifactId> </plugin>

@wrighting

This comment has been minimized.

Show comment
Hide comment
@wrighting

wrighting Nov 28, 2016

@gravitonian @jgoldhammer - you're both right.
The SDK3 does not minify the js or css files when building the war file, as you would expect it to.
Adding the plugin should fix in.
The thing to be careful about is to ensure that the correct filetypes are minified - not too many, and not too few.

wrighting commented Nov 28, 2016

@gravitonian @jgoldhammer - you're both right.
The SDK3 does not minify the js or css files when building the war file, as you would expect it to.
Adding the plugin should fix in.
The thing to be careful about is to ensure that the correct filetypes are minified - not too many, and not too few.

@ohej

This comment has been minimized.

Show comment
Hide comment
@ohej

ohej Mar 23, 2017

Collaborator

To avoid bloating the default pom.xml we ship out of the box, I would prefer to have this as a documentation feature. It is really about adding the plugin with the correct configuration.

Collaborator

ohej commented Mar 23, 2017

To avoid bloating the default pom.xml we ship out of the box, I would prefer to have this as a documentation feature. It is really about adding the plugin with the correct configuration.

@shazada

This comment has been minimized.

Show comment
Hide comment
@shazada

shazada Aug 17, 2017

Sorry to bump into this again, but I'm not really positive that it isn't there any more by default.
Then at least it should be commented in the generated share pom.xml so it's quite obvious.

We stumbled upon this out of the blue and in the mean time a lot of jar's were build and release without their minified versions.

Then again the Alfresco's own jars supplied in for example 5.1 have a difference on minified as well.
E.g. Aikau- versions supplied in 5.1 community aren't minified!
alfresco-googledocs-share*.jar is minified.

shazada commented Aug 17, 2017

Sorry to bump into this again, but I'm not really positive that it isn't there any more by default.
Then at least it should be commented in the generated share pom.xml so it's quite obvious.

We stumbled upon this out of the blue and in the mean time a lot of jar's were build and release without their minified versions.

Then again the Alfresco's own jars supplied in for example 5.1 have a difference on minified as well.
E.g. Aikau- versions supplied in 5.1 community aren't minified!
alfresco-googledocs-share*.jar is minified.

@douglascrp

This comment has been minimized.

Show comment
Hide comment
@douglascrp

douglascrp Nov 8, 2017

Contributor

@shazada Hello.
Have you found any solution for this?

@ohej How about the documentation on this topic?
Is it really going to be added anytime?

Contributor

douglascrp commented Nov 8, 2017

@shazada Hello.
Have you found any solution for this?

@ohej How about the documentation on this topic?
Is it really going to be added anytime?

@douglascrp

This comment has been minimized.

Show comment
Hide comment
Contributor

douglascrp commented Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment