New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change activation of enforce-sdk-rules so it's *really* on by default, as intended #352

Merged
merged 1 commit into from Feb 4, 2016

Conversation

Projects
None yet
2 participants
@michaeljmuller

michaeljmuller commented Feb 3, 2016

Maven's "active by default" does behave intuitively. If you turn on any other profiles, then the "active by default" ones are turned off.

As a result, using the "enterprise" profile turns off "enforce-sdk-rules", which I believe was unintended.

I use a bit of a hack to fix this (looking for a non-existent file).

From the maven docs: "All profiles that are active by default are automatically deactivated when a profile in the POM is activated on the command line or through its activation config."

http://maven.apache.org/guides/introduction/introduction-to-profiles.html

@ohej ohej added this to the 2.2.0 milestone Feb 4, 2016

ohej added a commit that referenced this pull request Feb 4, 2016

Merge pull request #352 from michaeljmuller/master
change activation of enforce-sdk-rules so it's *really* on by default, as intended

@ohej ohej merged commit 5b83b99 into Alfresco:master Feb 4, 2016

@ohej

This comment has been minimized.

Show comment
Hide comment
@ohej

ohej Feb 4, 2016

Collaborator

Thanks for the contribution! :)

Collaborator

ohej commented Feb 4, 2016

Thanks for the contribution! :)

ohej added a commit that referenced this pull request Feb 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment