New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT-17527 Add support for annotation layer #2

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@yregaieg

yregaieg commented Sep 12, 2017

In order to have clickable links in PDFJS viewer in Alfresco Share, the annotation layer needs to be rendered. In this PR, I added the support for this feature and added an activation flag (defaulting to true) as discussed with @esplinr.
Alfresco can switch that back to false by default and have a config entry (in share-config-custom.xml for instance) defining that setting.
IMHO it should be active by default (as it was with the swf previews back in 4.x) and customers can opt out of the feature by a simple extension setting the activation flag to false.

@davidcognite

This comment has been minimized.

Show comment
Hide comment
@davidcognite

davidcognite Sep 14, 2017

Member

Thanks for the PR! As referenced in the title, we've already got an MNT ticket for this: https://issues.alfresco.com/jira/browse/MNT-17527 - so will continue the discussion there about getting this fix reviewed and merged.

Member

davidcognite commented Sep 14, 2017

Thanks for the PR! As referenced in the title, we've already got an MNT ticket for this: https://issues.alfresco.com/jira/browse/MNT-17527 - so will continue the discussion there about getting this fix reviewed and merged.

@@ -1902,7 +1913,7 @@
this.textLayerDiv = null;
this.config = config || {};
this.textContent = null;
this.textLayerDiv = null;
this.annotationLayerDiv = null;

This comment has been minimized.

@douglascrp

douglascrp Sep 14, 2017

It seems you removed the parameter variable textLayerDiv here

@douglascrp

douglascrp Sep 14, 2017

It seems you removed the parameter variable textLayerDiv here

This comment has been minimized.

@douglascrp

douglascrp Sep 14, 2017

Forget it. You created a copy of the original one, and then changed it to annotationLayerDiv... sorry

@douglascrp

douglascrp Sep 14, 2017

Forget it. You created a copy of the original one, and then changed it to annotationLayerDiv... sorry

This comment has been minimized.

@yregaieg

yregaieg Sep 15, 2017

@douglascrp well... I reused an existing (duplicate property), instead of adding a new one..

@yregaieg

yregaieg Sep 15, 2017

@douglascrp well... I reused an existing (duplicate property), instead of adding a new one..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment