Skip to content

AliSoftware
AliSoftware

@AliSoftware

Closed via #90

@AliSoftware
Build loops when using storyboards
@AliSoftware

Hey @MrAlek The next release of SwiftGen (which will be released very soon, just waiting for a last-minute PR to finish) will include #90, which w…

@AliSoftware
  • @AliSoftware 51f6bad
    Added entry in CHANGELOG for #88
@AliSoftware
AliSoftware merged pull request AliSoftware/SwiftGen#90
@AliSoftware
Don't write unchanged contents to file
8 commits with 15 additions and 8 deletions
AliSoftware commented on pull request AliSoftware/Reusable#11
@AliSoftware

Thanks for the PR! Why not applying the same changes to UITableViewHeaderFooter views and UICollectionViewSupplementaryViews? Also, could you add a…

@AliSoftware
  • @AliSoftware 66a61a4
    [Monads] Add edit to talk about monad laws and Rui Peres' article
@AliSoftware
  • @AliSoftware 0febe1e
    [Monads] Add edit to talk about monad laws and Rui Peres' article
AliSoftware commented on issue realm/SwiftLint#518
@AliSoftware

Sorry, I hit the submit button too early by mistake. Comment edited.

AliSoftware commented on issue realm/SwiftLint#518
@AliSoftware

Yeah I see your point. But given how many commands related to configuration might be added, I found grouping them might be nice. As an example, in …

AliSoftware commented on issue realm/SwiftLint#518
@AliSoftware

@scottrhoyt I just opened #532 as I think this idea is great but we could bring it even further with an even more generic swiftlint config command …

@AliSoftware
Add a subcommands to check for the .swiftlint.yml syntax and path
@AliSoftware
Add a `swiftlint config` subcommand
@AliSoftware
Allow `swiftlint -h` and `swiftlint --help` for all subcommands
AliSoftware commented on pull request AliSoftware/SwiftGen#66
@AliSoftware

Given the existence of Reusable now, not sure if this feature is still worth it?

AliSoftware commented on pull request AliSoftware/SwiftGen#90
@AliSoftware

Btw did you check what happens if the output file doesn't exist? I mean, I hope it doesn't throw in that case — not being able to read a non-existi…

AliSoftware commented on pull request AliSoftware/SwiftGen#90
@AliSoftware

It seems like putting the try in front of the whole expression might work. What about this: if try onlyIfChanged && path.read(NSUTF8StringEncoding)…

AliSoftware commented on pull request AliSoftware/SwiftGen#90
@AliSoftware

Just nitpicking here, but I have to admit I feel like the name of this method sounds a bit Objective-C-y to me? Open to suggestions as to what woul…

AliSoftware commented on pull request AliSoftware/SwiftGen#90
@AliSoftware

Great, thanks a lot for the PR! :+1: Don't forget to add an entry in the CHANGELOG.md to credit yourself :wink:

AliSoftware commented on pull request AliSoftware/SwiftGen#90
@AliSoftware

I think inverting the order of the test (onlyIfChanged && try path.isContentEqualTo(content)) would be more efficient, so it doesn't read the file …

AliSoftware commented on pull request AliSoftware/SwiftGen#90
@AliSoftware

I think this helper function is not really needed. Directly call write(…, onlyIfChanged: true) everywhere we want this behavior is sufficient, havi…

AliSoftware commented on pull request AliSoftware/Reusable#10
@AliSoftware

2.1.1 is out :nada: (with this PR + 2 small other implementation detail fixes I just added) Thx for your contribution!

@AliSoftware
@AliSoftware
Migrate from `as!` to `guard let else fatalError(…)` construct
@AliSoftware
Protocols need to use String(self) rather than String(Self)
AliSoftware commented on issue AliSoftware/Reusable#2
@AliSoftware

Closed by 5cc715c

@AliSoftware
Something went wrong with that request. Please try again.