Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added JobberBase detection #66

Closed
wants to merge 3 commits into
from

Conversation

3 participants
Contributor

tbenjis commented May 3, 2012

Just added JobberBase detection and Icon

Owner

AliasIO commented May 3, 2012

Thanks! Because of a previous merge I can't automatically pull your changes in, can you update your fork and submit another pull request?

I don't think we need a whole new category. Can you added JobberBase to the "Miscellaneous" category for now?

I also think the pattern is slightly too loose as it will match any page containing "Jobber.jobber_url" (including this Github page). I don't mind tweaking this myself though.

@AliasIO AliasIO closed this May 3, 2012

Contributor

ooflorent commented May 3, 2012

Let's do a rebase!
You should provide a PNG icon file, not an ICO.

Contributor

tbenjis commented May 3, 2012

Oh I will try to tweak the detection and provide a PNG icon file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment