[MCH] Some cleanup / simplification (and one bug fix) in mapping tests #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In future, I think it would be useful to avoid "forgot clang-format" commits. In most cases in makes sense to do |
|
Agreed. |
mikesas
pushed a commit
to mikesas/AliceO2
that referenced
this pull request
Dec 13, 2022
* Out of line code to reduce memory usage while compiling pidTPC tasks * Change to use an array for the intermediate tracks representation. It would probably be better to read directly the values from the arrow tables, but that will come in a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides some internal reorganisation of the tests (split in regular and "long"), and a bug fix (found by doing the go implementation of the mapping btw...) the only maybe controversial point in this PR is the addition of a json data test file of 158KB (https://alice-talk.web.cern.ch/t/testdata-location-for-boost-tests/46)
That test file is actually not used by default in the tests unless a
--testposis used when callingtest_MCHMapping(which I actually don't know how to achieve with ctest)