PWGHF: Unify different partitions in Ds task#8035
Merged
Merged
Conversation
…d::map in Ds task
fchinu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli and
vkucera
as code owners
Please consider the following formatting changes to AliceO2Group#8035
fchinu
changed the title
auto-merge was automatically disabled
October 18, 2024 10:01
Head branch was pushed to by a user without write access
Member
|
@fchinu I took a closer look at the code, and what you are doing with selecting preslice is in fact redundant. Since you are always slicing on the MC collision index, there is no reason to have several instances of preslice, it is actually enough to have |
fchinu
changed the title
Contributor
Author
|
Thanks a lot @aalkin for your time and suggestions! I have changed the code following your advice, it is now much cleaner! |
Member
|
The code looks good, please go ahead and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the filling of the number of contributors in the Ds task output.
After an interesting chat with @aalkin, I was suggested to drop the usage of the
std::mapto indicate the partition to be used, as it increases both compilation and run time, and remove redundant multiple definitions of the partitions, as it is not needed to have different specialisations for the differentJoins.