From a4f94012c3abfc0cd7ff205ad88030b1c8183e32 Mon Sep 17 00:00:00 2001 From: Barthelemy Date: Thu, 12 Jan 2023 09:37:41 +0100 Subject: [PATCH 1/2] [QC-902] Turn on the discarding of debug messages by default. --- Framework/include/QualityControl/DiscardFileParameters.h | 2 +- Framework/src/QcInfoLogger.cxx | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Framework/include/QualityControl/DiscardFileParameters.h b/Framework/include/QualityControl/DiscardFileParameters.h index 292f1836b7..c863570743 100644 --- a/Framework/include/QualityControl/DiscardFileParameters.h +++ b/Framework/include/QualityControl/DiscardFileParameters.h @@ -23,7 +23,7 @@ namespace o2::quality_control::core { struct DiscardFileParameters { - bool debug = false; + bool debug = true; int fromLevel = 21 /* Discard Trace */; std::string discardFile; unsigned long rotateMaxBytes = 0; diff --git a/Framework/src/QcInfoLogger.cxx b/Framework/src/QcInfoLogger.cxx index cb06080f7f..8e11e0a401 100644 --- a/Framework/src/QcInfoLogger.cxx +++ b/Framework/src/QcInfoLogger.cxx @@ -79,6 +79,7 @@ void QcInfoLogger::init(const std::string& facility, ILOG_INST.filterDiscardSetFile(discardFileParameters.discardFile.c_str(), discardFileParameters.rotateMaxBytes, discardFileParameters.rotateMaxFiles, 0, true /*Do not store Debug messages in file*/); } ILOG(Debug, Ops) << "QC infologger initialized" << ENDM; + std::cout << "YYY : " << discardFileParameters.debug << std::endl; ILOG(Debug, Support) << " Discard debug ? " << discardFileParameters.debug << ENDM; ILOG(Debug, Support) << " Discard from level ? " << discardFileParameters.fromLevel << ENDM; ILOG(Debug, Support) << " Discard to file ? " << (!discardFileParameters.discardFile.empty() ? discardFileParameters.discardFile : "No") << ENDM; @@ -97,8 +98,9 @@ void QcInfoLogger::init(const std::string& facility, const std::string& partitionName) { DiscardFileParameters discardFileParameters; - std::string discardDebugStr = config.get("qc.config.infologger.filterDiscardDebug", "false"); + std::string discardDebugStr = config.get("qc.config.infologger.filterDiscardDebug", "true"); discardFileParameters.debug = discardDebugStr == "true"; + std::cout << "XXX : " << discardFileParameters.debug << std::endl; discardFileParameters.fromLevel = config.get("qc.config.infologger.filterDiscardLevel", 21 /* Discard Trace */); discardFileParameters.discardFile = config.get("qc.config.infologger.filterDiscardFile", ""); discardFileParameters.rotateMaxBytes = config.get("infologger.filterRotateMaxBytes", 0); From 27ecc7f4a0ea3c4a2ebb7a8506d9bda89ff5c0ab Mon Sep 17 00:00:00 2001 From: Barthelemy Date: Thu, 12 Jan 2023 09:38:13 +0100 Subject: [PATCH 2/2] remove cout --- Framework/src/QcInfoLogger.cxx | 2 -- 1 file changed, 2 deletions(-) diff --git a/Framework/src/QcInfoLogger.cxx b/Framework/src/QcInfoLogger.cxx index 8e11e0a401..9ff3571b56 100644 --- a/Framework/src/QcInfoLogger.cxx +++ b/Framework/src/QcInfoLogger.cxx @@ -79,7 +79,6 @@ void QcInfoLogger::init(const std::string& facility, ILOG_INST.filterDiscardSetFile(discardFileParameters.discardFile.c_str(), discardFileParameters.rotateMaxBytes, discardFileParameters.rotateMaxFiles, 0, true /*Do not store Debug messages in file*/); } ILOG(Debug, Ops) << "QC infologger initialized" << ENDM; - std::cout << "YYY : " << discardFileParameters.debug << std::endl; ILOG(Debug, Support) << " Discard debug ? " << discardFileParameters.debug << ENDM; ILOG(Debug, Support) << " Discard from level ? " << discardFileParameters.fromLevel << ENDM; ILOG(Debug, Support) << " Discard to file ? " << (!discardFileParameters.discardFile.empty() ? discardFileParameters.discardFile : "No") << ENDM; @@ -100,7 +99,6 @@ void QcInfoLogger::init(const std::string& facility, DiscardFileParameters discardFileParameters; std::string discardDebugStr = config.get("qc.config.infologger.filterDiscardDebug", "true"); discardFileParameters.debug = discardDebugStr == "true"; - std::cout << "XXX : " << discardFileParameters.debug << std::endl; discardFileParameters.fromLevel = config.get("qc.config.infologger.filterDiscardLevel", 21 /* Discard Trace */); discardFileParameters.discardFile = config.get("qc.config.infologger.filterDiscardFile", ""); discardFileParameters.rotateMaxBytes = config.get("infologger.filterRotateMaxBytes", 0);