From 5e2b5335cc322be8c9a7fab37a2ace6c1410e0c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barth=C3=A9l=C3=A9my=20von=20Haller?= Date: Fri, 31 May 2024 09:35:15 +0200 Subject: [PATCH] Add a few safeguards to o2-qc-repo-update-run-type --- .../qcrepocleaner/o2-qc-repo-update-run-type | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Framework/script/RepoCleaner/qcrepocleaner/o2-qc-repo-update-run-type b/Framework/script/RepoCleaner/qcrepocleaner/o2-qc-repo-update-run-type index a3cfdba2c9..615f9a5a1a 100755 --- a/Framework/script/RepoCleaner/qcrepocleaner/o2-qc-repo-update-run-type +++ b/Framework/script/RepoCleaner/qcrepocleaner/o2-qc-repo-update-run-type @@ -51,7 +51,7 @@ def run(args): logging.fatal(f"Could not find columns `runNumber` and `runType` in {args.runs_file}, make sure the column headers are correct.") exit(1) - if run_type == "null": + if run_type == "null" or run_type == "": logging.debug(f"Skipping run {run_number} because its type is `null`") continue logging.debug(f"Run : {run_number} -> {run_type}") @@ -65,13 +65,21 @@ def run(args): logging.info(f"Number of versions found: {len(versions)}") total_planned += len(versions) for version in versions: + if "RunNumber" not in version.metadata: + logging.debug(f"{version} misses metadata RunNumber") + continue run_number = version.metadata["RunNumber"] if version.metadata["RunNumber"] not in mapping_run_types: - logging.debug(f"No mapping run {version.metadata['RunNumber']}") + logging.debug(f"{version} : No mapping for run {version.metadata['RunNumber']}") continue run_type = mapping_run_types[run_number] - logging.info(f"Ready to update {version} : \"{version.metadata['RunType']}\" -> \"{run_type}\"") + old_run_type = version.metadata['RunType'] if 'RunType' in version.metadata else "null" + if old_run_type != run_type: + logging.info(f"Ready to update {version} : \"{old_run_type}\" -> \"{run_type}\"") + else: + logging.info(f"Won't update {version} : run type is already {run_type}") + continue if args.print_list: continue