From be10b0c84dc90542bfa00f9dc6edc9157303b727 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20MOHIER?= Date: Mon, 15 May 2017 21:11:59 +0200 Subject: [PATCH] Clean Borg / MacroResolver classes - only comments --- alignak/borg.py | 6 +++++- alignak/macroresolver.py | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/alignak/borg.py b/alignak/borg.py index 9f4ff031d..e07e6cd6f 100644 --- a/alignak/borg.py +++ b/alignak/borg.py @@ -51,7 +51,11 @@ class Borg(object): # pylint: disable=R0903 """Borg class define a simple __shared_state class attribute. __dict__ points to this value when calling __init__ - TODO: Is this class really needed? Only subclassed by MacroSolver + This is used to make a Singleton-like pattern with a python object that inherits from the Borg. + + The Singleton design pattern (DP) has a catchy name, but the wrong focus -- on identity + rather than on state. The Borg design pattern has all instances share state instead, + and Python makes it, literally, a snap. """ __shared_state = {} diff --git a/alignak/macroresolver.py b/alignak/macroresolver.py index ffb817b8d..22754426a 100644 --- a/alignak/macroresolver.py +++ b/alignak/macroresolver.py @@ -59,7 +59,6 @@ import re import time -# import warnings from alignak.borg import Borg