Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 7 of clang compiler warning patches. #114

Closed
wants to merge 1 commit into from

Conversation

ethoms
Copy link
Contributor

@ethoms ethoms commented Nov 3, 2015

Stage 7:

Fixes a objc-method-access warning. The method is no longer in use, so I commented it out and made a TODO note to remove redundant methods.

@extrafu
Copy link
Contributor

extrafu commented Nov 4, 2015

This method is used by the SOGo extensions for Thunderbird.

@extrafu extrafu closed this Nov 4, 2015
@ethoms
Copy link
Contributor Author

ethoms commented Nov 5, 2015

OK, sorry about that, never thought about Thunderbird plugin. I'll try to rethink this one. There is another objc-method-access in this file that i also could not clear. So thees are the only 2 I can't clear so far. below is the clang warnings:

SOGoMailAccounts.m:227:37: error: instance method '-contentAsDOMDocument' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
      document = [[context request] contentAsDOMDocument];
                                    ^~~~~~~~~~~~~~~~~~~~
/usr/local/GNUstep/Local/Library/Headers/NGObjWeb/WOPageGenerationContext.h:28:8: note: receiver is instance of class declared here
@class WORequest, WOResponse;
       ^
SOGoMailAccounts.m:239:29: error: instance method '-textValue' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
          name = [labelNode textValue];
                            ^~~~~~~~~
2 errors generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants