Stage 1 of clang complier warning patches. These are mostly fixes for… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data type and casting inconsistencies. Also some string formatting fixes.
extrafu
added a commit
that referenced
this pull request
Oct 21, 2015
Stage 1 of clang complier warning patches. These are mostly fixes for…
| @@ -87,7 +87,7 @@ - (unsigned)readBytes:(void *)_buf count:(unsigned)_len { | |||
| { | |||
| register unsigned char *byteBuffer = _buf; | |||
|
|
|||
| for (_len = result - 1; _len >= 0; _len--, byteBuffer++) { | |||
| for (NSInteger len = result - 1; len >= 0; len--, byteBuffer++) { | |||
There was a problem hiding this comment.
This change broke my build on macppc, libobjc2, gcc-4.2.1:
NGByteCountStream.m: In function '-[NGByteCountStream readBytes:count:]':
NGByteCountStream.m:90: error: 'for' loop initial declaration used outside C99 mode
There was a problem hiding this comment.
and I see that is already addressed in 3778286, same thing I came up with by myself ;)
|
These have already been fixed by extrafu! What branch are you using? You should have the commit "(fix) c99 fixes" (3778286). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… data type and casting inconsistencies. Also some string formatting fixes.
These are patches that come from a code cleanup exercise trying to clear as many clang compiler warnings as possible. But they should apply to any build environement.
Note that the SOPE and SOGo both build sucessfully after these and many other patches have been applied. Also, I've been running in production for a few days without any issues. However I have not done any unit testing.