Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 3 of clang compiler warning patches. Replace deprecated 'isa' c… #25

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

ethoms
Copy link
Contributor

@ethoms ethoms commented Oct 24, 2015

…alls.

Stage 3: CAUTION
These fix deprecated 'isa' calls by using object_getClass and object_setClass. This may cause problem with older compilers/objc libraries.

@buzzdeee
Copy link

Tested this, together with the others up to stage8 of the clang fixes on:
OpenBSD -current

  • amd64, clang-3.5, libobjc2-1.8
  • i386, clang-3.5, libobjc2-1.8
  • macppc, gcc-4.2.1, libobjc2-1.8
    No issues so far, besides my comment on the stage8 fix

@extrafu
Copy link
Contributor

extrafu commented Nov 3, 2015

This will break Ubuntu Lucid builds. GNUstep under Lucid does not provide the Objective2 bundle so object_getClass is undefined.

Lucid LTS reached EOL - I guess it's time for us to drop it.

@ethoms
Copy link
Contributor Author

ethoms commented Nov 3, 2015

OK, I thought RHEL 5.11 was the oldest supported runtime to test against. If you want, I'll try to come up with a solution. I could add some #if statements to check for lack of Objective2 and then #define a substitution back to 'isa'. Just let me know if that's necessary.

extrafu added a commit that referenced this pull request Nov 4, 2015
Stage 3 of clang compiler warning patches. Replace deprecated 'isa' c…
@extrafu extrafu merged commit 8ed64e8 into Alinto:master Nov 4, 2015
@ethoms ethoms deleted the clang-warnings-stage3 branch November 27, 2015 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants