Stage 4 of clang compiler warning patches. Various code cleanup and f… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [mes release]; mes = nil; | ||
| [pool release]; | ||
|
|
||
| return [m autorelease];; | ||
| return [a autorelease];; |
There was a problem hiding this comment.
why not remove the stray semicolon here?
|
Good point, I never noticed it. Clang doesn't complain about it either. If I have the need to patch that file again, I'll try to remember to remove it. I think that was one of David's patches, so I never tried to understand it. |
|
Tested this, together with the others up to stage8 of the clang fixes on:
|
extrafu
added a commit
that referenced
this pull request
Nov 3, 2015
Stage 4 of clang compiler warning patches. Various code cleanup and f…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ixes.
Stage 4:
Various code cleanup and fixes. Mostly made by David Chisnall from patches that date back to Oct 2013.