-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a images_to_alt option to discard images and keep only their alt #49
Conversation
@@ -0,0 +1,2 @@ | |||
[ ALT TEXT ](http://example.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason for having space
around alt text [ ALT TEXT ]
why it can't be stripped ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alir3z4 Well, it's more related to how the o()
method handle its output. Honestly, changing that method behavior for my option seems overkill to me, what would you suggest ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JocelynDelalande You're right, for now I don't think it would be a good idea to touch o
since it might mess up all the unit-tests.
This change is fine then ;)
@JocelynDelalande Is this gonna work if there's no |
Yes, it just outputs nothing. |
Awesome. |
added a images_to_alt option to discard images and keep only their alt Thanks @JocelynDelalande
That's specially useful when you have big banner images in emails with an alt name.