Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a images_to_alt option to discard images and keep only their alt #49

Merged
merged 1 commit into from
Dec 23, 2014

Conversation

JocelynDelalande
Copy link
Contributor

That's specially useful when you have big banner images in emails with an alt name.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) when pulling c5d59f7 on oasiswork:jd-image_to_alt into 100ae75 on Alir3z4:master.

@@ -0,0 +1,2 @@
[ ALT TEXT ](http://example.com)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any specific reason for having space around alt text [ ALT TEXT ] why it can't be stripped ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alir3z4 Well, it's more related to how the o() method handle its output. Honestly, changing that method behavior for my option seems overkill to me, what would you suggest ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JocelynDelalande You're right, for now I don't think it would be a good idea to touch o since it might mess up all the unit-tests.

This change is fine then ;)

@Alir3z4
Copy link
Owner

Alir3z4 commented Dec 22, 2014

@JocelynDelalande Is this gonna work if there's no alt on images? will the image be removed if there's no alt on the image ?

@JocelynDelalande
Copy link
Contributor Author

@JocelynDelalande Is this gonna work if there's no alt on images? will the image be removed if there's no alt on the image ?

Yes, it just outputs nothing.

@Alir3z4
Copy link
Owner

Alir3z4 commented Dec 23, 2014

Yes, it just outputs nothing.

Awesome.

Alir3z4 added a commit that referenced this pull request Dec 23, 2014
added a images_to_alt option to discard images and keep only their alt

Thanks @JocelynDelalande
@Alir3z4 Alir3z4 merged commit b4d4191 into Alir3z4:master Dec 23, 2014
@Alir3z4 Alir3z4 mentioned this pull request Dec 26, 2014
@n11c n11c deleted the jd-image_to_alt branch September 13, 2016 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants