change to GitHub Flow #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sot528
commented
Aug 2, 2019
| executor: | ||
| name: python3_6_1 | ||
|
|
||
| executor: python3_6_1 |
| steps: | ||
| - deploy-resources: | ||
| target: 'function' | ||
|
|
||
| deploy-function-production: *deploy-function |
There was a problem hiding this comment.
ワークフローを分けたためproduction専用のジョブは不要となりました。
| @@ -303,7 +286,7 @@ jobs: | |||
| - v1-npm-dependencies- | |||
|
|
|||
| - run: | |||
| command: npm i | |||
| command: npm ci | |||
There was a problem hiding this comment.
ついでにpackage-lock.jsonを使用するよう変更。
ghost
requested review from
|
LGTM です！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
環境変数(SSMパラメータ)
影響範囲(システム)
影響範囲(開発者)
技術的変更点概要
CIの変更点
以下のようなCIワークフローとした。
フォークしたリポジトリ
masterにマージしたときのステージング
masterにマージしたときの本番環境
DBやDBへのクエリに対する変更
ブロックチェーンへの影響
トークンの扱いに関する修正か
CDN(Cloudfront)への修正があるか
ElasticSearchへの修正があるか
CloudFormationスタック間の依存関係に変更はあるか
個人情報の取り扱いに変更のあるリリースか
テスト結果とテスト項目
注意点・その他
お願いしたいこと
PRをマージ後、そのままdevelopをmasterにマージしてステージング環境へ反映されることをご確認ください。本番環境へのビルドは放置でおｋです。