Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapters don't open upon click in the bookmarks page #74

Closed
braiam opened this issue Apr 23, 2013 · 0 comments
Closed

Chapters don't open upon click in the bookmarks page #74

braiam opened this issue Apr 23, 2013 · 0 comments
Assignees
@braiam
Labels
bug

Comments

@braiam
Copy link
Member

braiam commented Apr 23, 2013

The line 385 and 284 adds a inline javascript onclick function, so when trying to click it trows an exception.
I remember that we do some magic in the popup, maybe we could copy the technique.
@ghost ghost assigned braiam Apr 29, 2013
@braiam braiam closed this as completed in 2611382 Apr 29, 2013
braiam added a commit that referenced this issue Jun 3, 2013
@braiam
Merge branch 'release/1.5.3'
db40338 
* release/1.5.3: (24 commits)
  Ignoring wiki in the backsite.js
  Fix regresion due the change of order
  Trim the search term to prevent trailing spaces spoil the search
  Unescape the urlencoding
  Bumping version
  Changing year of footer
  Added a function to search from the context menu any selected text
  Added a method to use the search function from the url
  Cleaning comments
  Partial fix of issue #77
  Changing vendor specific css rule for generic one
  Fixes #74
  Removed releases notes related files
  Asseting issue #73
  Fix valMg being undefined
  Reorder the inclution of the css and js files
  Fix #72
  JSLint of bookmark.js
  Corrected image extension
  Fix unchanging icon
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@braiam braiam

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@braiam