Replace xpmr.c #define with new voxhangtime usbradio.conf parameter #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix for Issue #33. Replace xpmr.c '#define XPMR_VOX_HANGTIME' with a new 'voxhangtime' cfg parameter set in usbradio.conf. When using usbradio in carrierfrom=vox mode this is the value the vox hang timer pChan->rxVoxTimer is set to in xpmr.c each time RX audio is detected. Making it configurable allows the default value of 2000mS to be reduced to a shorter time thereby preventing 2 seconds of silence being added to all node user transmissions. A value of 500mS seems to be much more optimal, and in my testing resulted in no false RX CD drops even when not talking. (xpmr.c's vox mode detects even quiet background noise and thereby supports reliable COS detection for radios that do not have a hardware COS line output.) Add the new voxhangtime parm to chan_usbradio.c chan_usbradio_pvt struct, store_config(), xpmr.c createPmrChannel(), xpmr.h t_pmr_chan struct, and to asterisk/configs/usbradio.conf.sample and allstar/configs/usbradio/usbradio.conf.