New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niagara prefixes #31

Open
drichardson opened this Issue Jan 11, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@drichardson
Copy link

drichardson commented Jan 11, 2019

Niagara has more asset types than Cascade. Whereas Cascade had Particle System, Niagara has:

  • Emitter
  • System
  • Module
  • Function Script (similar to module, both implemented by UNiagaraScript)

I'd like to see these added to the style guide. I don't have a strong opinion about any of the following proposals, just using them to start the conversation.

Proposal 1

Separate prefix for each type, suffix for 1 variation (function script, which is almost the same as a module under the hood).

Asset Type Prefix Suffix Notes
Niagara Emitter NE_
Niagara Module NM_
Niagara Function Script NM_ _S
Niagara System NS_

Proposal 2

Same prefix, different suffix for each type.

Asset Type Prefix Suffix Notes
Niagara Emitter N_ _E
Niagara Module N_ _M
Niagara Function Script N_ _F
Niagara System N_ _S

Proposal 3

Reuse current ParticleSystem prefix and add suffixes for each type.

Asset Type Prefix Suffix Notes
Niagara Emitter PS_ _E
Niagara Module PS_ _M
Niagara Function Script PS_ _F
Niagara System PS_ _S
@Allar

This comment has been minimized.

Copy link
Owner

Allar commented Jan 11, 2019

I'm a fan of both 1 and 3, but I have zero Niagara experience. Would like input from those that do.

@drichardson

This comment has been minimized.

Copy link

drichardson commented Jan 11, 2019

I have about 5 minutes more experience than you do. You saw I pinged a couple of Niagara devs on twitter for their input, hopefully they respond.

@drichardson

This comment has been minimized.

Copy link

drichardson commented Jan 12, 2019

I put a post in the UE4 rendering forum to try to elicit more feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment